Received-SPF: pass (google.com: domain of linux-wireless+bounces-6643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <01fc6041e04b05ac6909a9818c9a890628542373.camel@sipsolutions.net>
Subject: Re: [PATCH 7/7] wifi: mac80211_hwsim: add support for BSS color
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Mon, 22 Apr 2024 10:15:12 +0200
In-Reply-To: <20240416045943.576656-8-quic_adisi@quicinc.com>
References: <20240416045943.576656-1-quic_adisi@quicinc.com>
	 <20240416045943.576656-8-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-04-16 at 10:29 +0530, Aditya Kumar Singh wrote:
> Advertise support for BSS color and then once the countdown reaches 0,
> call color change finish.
>=20
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> ---
>  drivers/net/wireless/virtual/mac80211_hwsim.c | 6 ++++++
>=20

Not quite related to this patch, but I wonder ... what are you testing
with this? How?

Seems like we should actually filter on BSS color in hwsim on RX
somehow? We don't have PPDUs per se, so we'd have to tag it somewhere
else, but that's doable?

Otherwise are we even testing all of this fully?

johannes