Received-SPF: pass (google.com: domain of linux-wireless+bounces-6646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <99cbc879-3cbd-4c35-b5dd-991f8871607e@quicinc.com>
Date: Mon, 22 Apr 2024 14:18:03 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 7/7] wifi: mac80211_hwsim: add support for BSS color
To: Johannes Berg <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>
References: <20240416045943.576656-1-quic_adisi@quicinc.com>
 <20240416045943.576656-8-quic_adisi@quicinc.com>
 <01fc6041e04b05ac6909a9818c9a890628542373.camel@sipsolutions.net>
Content-Language: en-US
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <01fc6041e04b05ac6909a9818c9a890628542373.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 4/22/24 13:45, Johannes Berg wrote:
> On Tue, 2024-04-16 at 10:29 +0530, Aditya Kumar Singh wrote:
>> Advertise support for BSS color and then once the countdown reaches 0,
>> call color change finish.
>>
>> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
>> ---
>>   drivers/net/wireless/virtual/mac80211_hwsim.c | 6 ++++++
>>
> 
> Not quite related to this patch, but I wonder ... what are you testing
> with this? How?
>

I'm testing only color change done via user space for now. Currently 
hostapd does not have support for that but I have changes for it too. So 
after adding cli support, I have added hw_sim test cases to test and 
validate it (non-MLO or HE scenario as well as MLO). And like CSA, 
currently for MLO, color change test only on first link. Non-first link 
will be added later.

> Seems like we should actually filter on BSS color in hwsim on RX
> somehow? We don't have PPDUs per se, so we'd have to tag it somewhere
> else, but that's doable?
> 

Yeah seems like but need to deep dive. Have not thought about this yet.

> Otherwise are we even testing all of this fully?

Not fully. As an initial step, currently supporting changes via cli. 
Then we can add the required RX details via some means so that when it 
reports packets to mac80211, color collision detection can automatically 
happen.