Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2214643lqt; Mon, 22 Apr 2024 05:07:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUo2V7zNta3+Wx2KD8WBqIEP5MWGr2r00TB/HZD9bW4IhabHSZfyC1pdJ5YX+pk8FapZxIbIn9+kNm9ZiwXS2cLb28ohT7JI+7cy4zodA== X-Google-Smtp-Source: AGHT+IH7OI0g+X94F2lFbyQB30xpWWzErOUA98WKS7adqesRLd+hfwyudxqfP/wmq/S3iwV+DKKb X-Received: by 2002:a05:622a:1103:b0:439:9235:a09c with SMTP id e3-20020a05622a110300b004399235a09cmr6242374qty.9.1713787621205; Mon, 22 Apr 2024 05:07:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713787621; cv=pass; d=google.com; s=arc-20160816; b=m84HbEJ/bUVhzfJQnPiqXlVLWiIVpYftL+9KcFHCQrIQzyQ9jOUBIF6pVX+Pdubni7 oi75jH3JDXWO22WycRYvrkD3ofxOwq3yi471XQOoaSd5+fPci0oNSOBqsw2rW06KMQXN 6/6tyfartN1yQl3JPsHHoOmZea8MkDLk7Wj4XyiCyiBhdoDDFocS2lxCf9va7EfGFBR8 cpo81n83SlDsgXIX1qpiP7bZL5GFoztlaJ5BzWkVOVB9Fla5dMZ+Uk92JHdf3NKke/qj aA7/vBJDE3+HPu66UzUMMXx1J06rmXjxcxwZ148MHFYlhZMeJD8udcMNGMDfOsl1p3GB dJEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=ygc40s/zkvTqNRi1ZwybmSdQay1JOH4ABIMjWdhf0Xg=; fh=TNMk+ReiLDicE88zeGxH5H7qxxS5WfM5w7j5sKHBLUs=; b=kveyc7Kz8BJmDi9tYNDplslhcEg288L3fVhMYVUCTUGtRlXpGf25BMIq5n0RAZnkgQ GPH9ZNRq2mNqA1xvUl6utf4Jxvn50fzJluVfBAk5hkLgAJC7U8WObPNwnDDsZe2oP6GE earVUzxQurvW+faQbGzGP9bVNfVuq5L6V2EUwp8jhETxMWpOxd1MJsSK7eLJTS9vmEQg f7OWVqnHQOQYk+rICwtvDXoYEd2ZHGEFEHDk9yOMFahAiUbxnvVpn1hj/wpgQiCcAWFy ITl7QYICBHlUhz7wZTzzzzrsiqqh0hEwfgIOi8amiBcbYpPFxSq5I2+DHshchvh8KpVW E9UA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="B8Bp1lz/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6648-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6648-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p9-20020a05622a00c900b00437a85aaeb3si9701356qtw.241.2024.04.22.05.07.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 05:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6648-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="B8Bp1lz/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6648-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6648-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E409F1C2098E for ; Mon, 22 Apr 2024 12:06:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6235D1465A6; Mon, 22 Apr 2024 12:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B8Bp1lz/" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E2E01311AD for ; Mon, 22 Apr 2024 12:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713787611; cv=none; b=EI68wyz59sEN6Z7CeTF8LAcHdMFusLshlm+DRKi6yAspp1Bjj+qpnD29eNXBaRJmY5Rz0qV5IvC7xqxCv1L9l3oWqDep6Njwqb33J1wwrsX+KSvwBIl81+gMZcIj6rsPQvQaGGoY6vGMf6BrGdkoL+StRsPAOZ+rkXU+7ElX94Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713787611; c=relaxed/simple; bh=vALtas8Ie8tYQHKOrKFZueYSxtZc7LSpUj9elN4mV3w=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=PCVUeXzjt41920zSxpVu5l71J9L2WMYU5lfrfoEOl5cBg4UEN3NtTheWMhUSUUBzqWMc4xQIn6MMxLfwBq3PgxCS7YtZva3MItkd5eIehKSSK06b+2ohku3GHHfFKwzN8aE8ZqO3HLxFzLvbGWnwMB+t9N6W2jBYVXBapgDzWdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B8Bp1lz/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CB9CC113CC; Mon, 22 Apr 2024 12:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713787610; bh=vALtas8Ie8tYQHKOrKFZueYSxtZc7LSpUj9elN4mV3w=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=B8Bp1lz/aEWjgCh30IyuZb4Kcs0ZB9B3tDnLqbjmVbQUfpZtNHhJgHiC51zIKfLn6 1OE20tj08IRFZdVLjL6t69HOkFqkJpW9HRUo8QT8Er1PhwDSekRsFRs+x4yUWDyg6c yFf4MaeeYsfgt4G0zT0StGPqa2kehOBFu63ttUR0S1rV7gREvuV9afrTl7Gvj9w2Il hw6EC4/23uE8Q25QaPetQThGm7rWhP/+QnuHJPWSjhkBkec2YB++u4dBHBIja/6dQi BHZgebDQYm7okUgjcqps8ceJM1foznnVylw6DMaSIgn1tdBZdbZxaqVth0g6QKjBvr 5axzNtLqFTo8Q== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/4] wifi: ath12k: avoid redundant code in Rx cookie conversion init From: Kalle Valo In-Reply-To: <20240411102226.4045323-2-quic_periyasa@quicinc.com> References: <20240411102226.4045323-2-quic_periyasa@quicinc.com> To: Karthikeyan Periyasamy Cc: , , Karthikeyan Periyasamy , Jeff Johnson User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171378760774.1358009.4155348032452693062.kvalo@kernel.org> Date: Mon, 22 Apr 2024 12:06:49 +0000 (UTC) Karthikeyan Periyasamy wrote: > Currently, in the Rx data path cookie conversion initialization procedure, > the primary page table index (ppt_idx) is computed within the secondary > page table iteration. However this is invariant, and hence the ppt_idx > should be calculated outside of the iteration to avoid repeated execution > of the statement. > > Found in code review. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Karthikeyan Periyasamy > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo 4 patches applied to ath-next branch of ath.git, thanks. 3ea19127d154 wifi: ath12k: avoid redundant code in Rx cookie conversion init b3e9e82b31c0 wifi: ath12k: Refactor the hardware cookie conversion init 682ca418d40a wifi: ath12k: displace the Tx and Rx descriptor in cookie conversion table d4e3fc4f45c6 wifi: ath12k: Refactor data path cmem init -- https://patchwork.kernel.org/project/linux-wireless/patch/20240411102226.4045323-2-quic_periyasa@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches