Received-SPF: pass (google.com: domain of linux-wireless+bounces-6649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] wifi: ath12k: fix out-of-bound access of
 qmi_invoke_handler()
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20240416080234.2882725-1-quic_kathirve@quicinc.com>
References: <20240416080234.2882725-1-quic_kathirve@quicinc.com>
To: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
 Karthikeyan Kathirvel
	<quic_kathirve@quicinc.com>, Jeff Johnson <quic_jjohnson@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <171378767925.1358009.1322280791259157852.kvalo@kernel.org>
Date: Mon, 22 Apr 2024 12:08:00 +0000 (UTC)

Karthikeyan Kathirvel <quic_kathirve@quicinc.com> wrote:

> Currently, there is no terminator entry for ath12k_qmi_msg_handlers hence
> facing below KASAN warning,
> 
>  ==================================================================
>  BUG: KASAN: global-out-of-bounds in qmi_invoke_handler+0xa4/0x148
>  Read of size 8 at addr ffffffd00a6428d8 by task kworker/u8:2/1273
> 
>  CPU: 0 PID: 1273 Comm: kworker/u8:2 Not tainted 5.4.213 #0
>  Workqueue: qmi_msg_handler qmi_data_ready_work
>  Call trace:
>   dump_backtrace+0x0/0x20c
>   show_stack+0x14/0x1c
>   dump_stack+0xe0/0x138
>   print_address_description.isra.5+0x30/0x330
>   __kasan_report+0x16c/0x1bc
>   kasan_report+0xc/0x14
>   __asan_load8+0xa8/0xb0
>   qmi_invoke_handler+0xa4/0x148
>   qmi_handle_message+0x18c/0x1bc
>   qmi_data_ready_work+0x4ec/0x528
>   process_one_work+0x2c0/0x440
>   worker_thread+0x324/0x4b8
>   kthread+0x210/0x228
>   ret_from_fork+0x10/0x18
> 
>  The address belongs to the variable:
>   ath12k_mac_mon_status_filter_default+0x4bd8/0xfffffffffffe2300 [ath12k]
>  [...]
>  ==================================================================
> 
> Add a dummy terminator entry at the end to assist the qmi_invoke_handler()
> in traversing up to the terminator entry without accessing an
> out-of-boundary index.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

e1bdff48a1bb wifi: ath12k: fix out-of-bound access of qmi_invoke_handler()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240416080234.2882725-1-quic_kathirve@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches