Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2253471lqt; Mon, 22 Apr 2024 06:08:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXcQ8aRQdcMljPO9lMjKfsy/2I5ar5kblzWoaKtbgkbn0GJREBjUa0OWvwTTnOqhEmgubno8PlbMz5ksqC30D5od1MLfO9Ls2CgKLfuVQ== X-Google-Smtp-Source: AGHT+IEidGRj+vD+EpeiZ5klLItyZoQQ+hST0BX5ysuYliejfhkiruvSofo+xC2ZJcdBwN5qIAN1 X-Received: by 2002:a05:651c:1039:b0:2dc:b04b:b3c0 with SMTP id w25-20020a05651c103900b002dcb04bb3c0mr5446074ljm.6.1713791310702; Mon, 22 Apr 2024 06:08:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713791310; cv=pass; d=google.com; s=arc-20160816; b=r8Da/0tgY1ArEDwrT+byCUHtyWQ5CJgewsIy+XQ2uFD2tNrGxSDkRPsLYXaQ3jER19 8jB07MHsneRvJls1ZI32XFbbHj8220fKMoIam1KedFYOEAaui6BNNZgdTpm1kS03wsdz Tl6y+DmyYuUwjJpXq81aRRY0K03bGbyHJz1/ICcbzcnW4f0+MhouJqG7ducm5dalabhd 0brepjckm8iRLylQQtQ5ZmIwbvGmnJ1nLIOjNuCa2zP323pqfDFC+dj4ptfWa4C7Lrh5 DJLXCM3gMKVf2KMAHtCnZtGQtdTxVQ+pVNywezILm7BMTNIEW+1uj0UhSEO9sCpYeawQ wcoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=ph0J1xRIjshjZvYoRwpUUVgK0fclROdsccWPhjoItKM=; fh=BrpGlYrucGNWpECFv+uH9FaK1QNAvXyUjp8ncjDcMx0=; b=sw5rWA/vCZf7WE+UGsmC+ElxuMUyT0sZc+UOEFCnltfgMWfiq8NdTINnpdOpGqfs2Y 8vMpmiK7L2P5IC5hHZsZWjtWLyitZowXdp+ach7bINO/FKnfd/ufM1ffLHmpKivvnNbD GEhsoRETau3LCKCItnl6bmv7WMqg1AdmOqOxEXksnBrpXt7B94TAf8fm252+SPBfTXVD bkvyEF/2bouCnDqUs8SL6E/UD6xByoBvq7knGRQ/BSkdU2oNCqMyxtNx2r7xcj+cB7WE t1Pa6qp6aBtxPcwxcXwnrwk14MLpNKpeB/KtuZe7a4/5QMuY8Q7Q4BohHxw+nFdiKSZE UJ2A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BWWeePq7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6667-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id x94-20020a50bae7000000b0056e22357f83si6027283ede.633.2024.04.22.06.08.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 06:08:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6667-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BWWeePq7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6667-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3CB831F20F33 for ; Mon, 22 Apr 2024 13:08:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10C5314F122; Mon, 22 Apr 2024 13:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BWWeePq7" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D418C14F11C; Mon, 22 Apr 2024 13:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713791306; cv=none; b=jwN8UiGBOOmx8Vc3N0H2C15pHMTUB5Yy/p4ulBdMLEcn/8NZt7CLYtFuYZrNEVBeNE1NsTrl7pm8OFQO3GM5PKGlKqJS2vNHLyySCMjGAeMKKjEsNNP3VvyQ93s0R9/GZ5ESwRCvEWMP+F2Vmpf2UQuf/kPB4ki0b57g8zL3Mzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713791306; c=relaxed/simple; bh=nznyQx8/p+3KHBmfBdZ9fWAd5pFk+wk0RpKca9y7nEY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=RnbD6vI42JOtZfaG5ghxQQTAi3iyIcaFDj+DG70xetXPxU63YyGnwEPmnsWxFxwvUCZwMK0eU/0Nvy20ZK7LQydSaWQPRMhb7CcdxtXq2jOTXI2lwGyp45AB+jQh8e69CgJZEjYrzSYtTTvuquOXeFiaBy6mKIyBRNqzTwSGo7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BWWeePq7; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CC6C113CC; Mon, 22 Apr 2024 13:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713791305; bh=nznyQx8/p+3KHBmfBdZ9fWAd5pFk+wk0RpKca9y7nEY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BWWeePq7vCnYC1rDnhl46rbfsAP83k7q/x3Q3lUzGSjnUMUQIhUqsdwSj7B+QHsUT TJxNZwu/It8/kfuDOxr+7fR/Gxuuekf9dThdZF6BE1JItRKXMPkSrq3frGiVH1r0xW L8fuputkj427+VfwNLdg4HGOQwxsr2FkSzbe/D7jbA7UK2aL7WgyRhtPTRyS1GEDSF U/R13zM6yHGfF4Ar2391FPP3Oe3dxjEg9FmMrVpke8K22WL35HrwSnsJUUE5HDiQ93 e9/YdctW7fGJnrZV7fkKjq+C4Ril6Qjq7t2VMHBijsJBRnEGzXkukWwVx+zT+XCVU/ HDX6k5rLN9hLw== From: Kalle Valo To: Breno Leitao Cc: aleksander.lobakin@intel.com, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, elder@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, taras.chornyi@plvision.eu, ath11k@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, geomatsi@gmail.com, Jeff Johnson , quic_jjohnson@quicinc.com, leon@kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, idosch@idosch.org, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com Subject: Re: [PATCH net-next v7 09/10] wifi: ath10k: allocate dummy net_device dynamically References: <20240422123921.854943-1-leitao@debian.org> <20240422123921.854943-10-leitao@debian.org> Date: Mon, 22 Apr 2024 16:08:18 +0300 In-Reply-To: <20240422123921.854943-10-leitao@debian.org> (Breno Leitao's message of "Mon, 22 Apr 2024 05:39:02 -0700") Message-ID: <87pluhv931.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Breno Leitao writes: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct ath10k by converting it > into a pointer. Then use the leverage alloc_netdev() to allocate the > net_device object at ath10k_core_create(). The free of the device occurs > at ath10k_core_destroy(). > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > > Signed-off-by: Breno Leitao I assume this goes via net-next: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches