Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2254194lqt; Mon, 22 Apr 2024 06:09:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUpnBvBoZf/5PGlgwuvVTAS/3lTBCDJeFPETJeOMWr77UHc8sEGC427uw7CFVcd9fbmq4Bx6v7jJxccSl8DVrqOnqttkooB/d0uv0parg== X-Google-Smtp-Source: AGHT+IEi3ZtMBYsRnoefAXO3nKJC4CCZmXB5S9seyoCeBRoP0woriiVIg9YOkDeZHVQ/LS2I1jJo X-Received: by 2002:a50:8add:0:b0:56e:2332:c282 with SMTP id k29-20020a508add000000b0056e2332c282mr6291089edk.14.1713791367829; Mon, 22 Apr 2024 06:09:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713791367; cv=pass; d=google.com; s=arc-20160816; b=vqSbmTpGr2wiB3XeidZyqx7TpcAY6M2bBiobF0f/ZoI1rK2Wb45otkeT5p1gQ5gsbz ax9l/78+mfrB5OdpHxrqkJBIT5br9uPT/Osn74vA7m9/UdAnQGmgcqiZ5i7OpZIJD3D+ 3H/fxepnIJ6VL5YkOLoVS1MOiBAvBd6KdtePFBWnb6OlKRhuh+3GH9Qq/H2RIYe7z0cQ mvK9PTcB/41bRk5q272yX1ZGzRyp4o4kzgjgz09N/r/B2/OKludA7KlMfLw8sZQHk7Cj yncQZMZUaf55m9qnT0XlWjoujKl254IwRNGFy4M9cxAUOeBvBNbhNmar96OyXoC1JfTm TeJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=2WIzLwkc4L4PpzEjdws2t5Tlw8sexrblA2Ahm8MDdgY=; fh=BrpGlYrucGNWpECFv+uH9FaK1QNAvXyUjp8ncjDcMx0=; b=jBvIcWl5jjOAu+6khWqG/D+Bnk1n0dW27MBLdWWftgzmg9IsYrsmlVUZ2Ad3hL3jrm 63NjmZgNV9quQ9xKUtvvU8N1L96/rUWMNMWWS1fsjTO3kDRlaPN97MxpTn3HqMT5rYGt mHWEly8k23L6q8lmXWF4Wc3lwTJnV5dFqey/1hReCwBnOQvWycb4vu8iCKYXgDqcUrOp N6i1G3Mhoy8Lb+ZsUtgSrg34I8ICVbQ+VIupfTl+lvXcF6/2MsZD43cihAnOcyCKTcBV Ya2cxnd8YA+V2EK4Vzpruys9Z/F8PTCWLIaKAr5C3wU+UuSLJQUNnrrpHRmvjPBXDOOA dBMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKj1Ev0s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6668-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x14-20020a50ba8e000000b00571b9a27539si5845201ede.684.2024.04.22.06.09.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 06:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKj1Ev0s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6668-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8D4351F213E4 for ; Mon, 22 Apr 2024 13:09:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 729EE14F9D9; Mon, 22 Apr 2024 13:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tKj1Ev0s" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4369614F9D4; Mon, 22 Apr 2024 13:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713791332; cv=none; b=W0qgamwXqdH2d4JSE/PyvI8FgP1KVl5T34iG/GSxED0S3N29RLjhbdYsIzD2QhX4dI5dk9wv7UVDBToFZTRoys5Kgns6Qj5ITmye+wvj2wM9YczezleK4ZcW+4SXu1ALkvL7mSWOaqNzOUzegEddSDLfp8Yn0LC1HqTWJnt8ETU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713791332; c=relaxed/simple; bh=J+i9N1KjmFk35PLTmY7h40rPANVS4NetGv5XWCcgOzg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=ti2U64yyM1TK1C7ZulpHO/BoSuDDCnWs941m21Milfm7hgR19V4V23jBRJbn5aG71hrK+TGED18uFRZcWvW2z78us8WmpKlyNYLNw+rpyrFp5Jgae6DefiUvhwIsabtVHzPfVZYIBJ9Iu5fNpzwGtQvmqT5v2KCySD560YnQMXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tKj1Ev0s; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19101C2BD11; Mon, 22 Apr 2024 13:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713791331; bh=J+i9N1KjmFk35PLTmY7h40rPANVS4NetGv5XWCcgOzg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=tKj1Ev0sDkQi5+KEiB5LhY1YrapyhqPWj1xhNyldEFOrjYMdLC2NQNywPIpM2oCn9 KKR+ldrGnJ0vgDJG4XgwKBgLI5FgxOu432nBCICrmXQSH+gCWW0UTDdlAhAQBILxdo xqF/R3vnu4jpugzmTn/hkZBf7SpnConYhE6huJdhyTx4EfL7nhXiFev8vfEpfZp+Lw L0pJcnsCn5VjnI/vxE0yT7hls74KwUcZ1ud9MZJyYKzX2kxFcFbVphu8ZJaYeFhTzP hCEBR8kB/Bdhv+iVxYObXPLD8tw+6rMlMYtLli9sAXUXAWh2sYW2PburZIAgpw4TBX ODeXWH+Ch2/IQ== From: Kalle Valo To: Breno Leitao Cc: aleksander.lobakin@intel.com, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, elder@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, taras.chornyi@plvision.eu, ath11k@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, geomatsi@gmail.com, Jeff Johnson , quic_jjohnson@quicinc.com, leon@kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, idosch@idosch.org, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com Subject: Re: [PATCH net-next v7 10/10] wifi: ath11k: allocate dummy net_device dynamically References: <20240422123921.854943-1-leitao@debian.org> <20240422123921.854943-11-leitao@debian.org> Date: Mon, 22 Apr 2024 16:08:44 +0300 In-Reply-To: <20240422123921.854943-11-leitao@debian.org> (Breno Leitao's message of "Mon, 22 Apr 2024 05:39:03 -0700") Message-ID: <87le55v92b.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Breno Leitao writes: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct ath11k_ext_irq_grp by converting it > into a pointer. Then use the leverage alloc_netdev() to allocate the > net_device object at ath11k_ahb_config_ext_irq() for ahb, and > ath11k_pcic_ext_irq_config() for pcic. > > The free of the device occurs at ath11k_ahb_free_ext_irq() for the ahb > case, and ath11k_pcic_free_ext_irq() for the pcic case. > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > > Signed-off-by: Breno Leitao > Tested-by: Kalle Valo I assume this goes via net-next: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches