Received-SPF: pass (google.com: domain of linux-wireless+bounces-6697-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3621bf61-732a-c2bc-c135-fbba299f8f57@nfschina.com>
Date: Tue, 23 Apr 2024 09:21:11 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in
 ath10k_dbg_sta_write_peer_debug_trigger()
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>
Cc: quic_jjohnson@quicinc.com, jjohnson@kernel.org, nathan@kernel.org,
 ndesaulniers@google.com, morbo@google.com, justinstitt@google.com,
 c_mkenna@qti.qualcomm.com, linux-wireless@vger.kernel.org,
 ath10k@lists.infradead.org, linux-kernel@vger.kernel.org,
 llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
From: Su Hui <suhui@nfschina.com>
In-Reply-To: <878r15j3bt.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/4/22 14:53, Kalle Valo wrote:
> Su Hui <suhui@nfschina.com> writes:
>
>> Clang Static Checker (scan-build) Warning:
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
>> Value stored to 'ret' is never read.
>>
>> Return 'ret' rather than 'count' when 'ret' stores an error code.
>> By the way, remove some useless code.
>>
>> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing")
>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> ---
>> v2:
>>   - remove the initializer change.
>>
>>   drivers/net/wireless/ath/ath10k/debugfs_sta.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
>> index 394bf3c32abf..c1198e9027ae 100644
>> --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
>> +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
>> @@ -432,14 +432,12 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file,
>>   
>>   	ret = ath10k_wmi_peer_set_param(ar, arsta->arvif->vdev_id, sta->addr,
>>   					ar->wmi.peer_param->debug, peer_debug_trigger);
>> -	if (ret) {
>> +	if (ret)
>>   		ath10k_warn(ar, "failed to set param to trigger peer tid logs for station ret: %d\n",
>>   			    ret);
>> -		goto out;
>> -	}
> Minimal changes with one logical change per patch, please. I'll remove
> this part in the pending branch.
>
Sorry for this, thanks for your help!

Su Hui