Received-SPF: pass (google.com: domain of linux-wireless+bounces-6713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <937ed41e-6915-426b-8098-01e95c8554c0@gmail.com>
Date: Tue, 23 Apr 2024 14:06:12 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 4/6] wifi: rtlwifi: Move code from rtl8192de to
 rtl8192d-common
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
 Stefan Lippers-Hollmann <s.l-h@gmx.de>,
 Christian Hewitt <chewitt@libreelec.tv>
References: <9d54a192-d389-4a56-9286-2e7721cbbc27@gmail.com>
 <459a193c-ce2e-4b89-827c-ff6721c470e0@gmail.com>
 <4e7bb78f7dad4383bc98f4a94a2c9b48@realtek.com>
 <509ded5b-6b31-4750-9f87-4d080ea4f71a@gmail.com>
 <054791df5141422fb0f8220eaeb66ff3@realtek.com>
Content-Language: en-US
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <054791df5141422fb0f8220eaeb66ff3@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 23/04/2024 03:48, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>> On 22/04/2024 05:55, Ping-Ke Shih wrote:
>>> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>>>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192d/main.c
>>>> @@ -0,0 +1,9 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
>>>> +
>>>> +#include "../wifi.h"
>>>> +#include <linux/module.h>
>>>> +
>>>> +MODULE_AUTHOR("Realtek WlanFAE <wlanfae@realtek.com>");
>>>> +MODULE_LICENSE("GPL");
>>>> +MODULE_DESCRIPTION("Realtek 8192D 802.11an common routines");
>>>
>>> Not sure why you emphasize '802.11an' instead of just '802.11n'.
>>>
>>>
>>
>> I saw somewhere a dual-band chip described as 802.11an.
>> It seemed like a good idea. Should I change it?
> 
> 
> I'm not sure what '802.11an' defines, but this old chip should not support that.
> Then, maybe '802.11an' here means '802.11a/802.11n', but I still don't know the
> relation with dual-band chip.
> 
> FYI:
> 802.11a: 5GHz band, CCK/OFDM
> 802.11b: 2GHz band, CCK
> 802.11g: 2GHz band, CCK/OFDM
> 802.11n: 2/5GHz bands, HT
> 

Ohh, right, there is probably something officially called
"802.11an". I will change it back then.