Received-SPF: pass (google.com: domain of linux-wireless+bounces-6734-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9d75e329-742f-4d3a-bdf6-52ed4de47488@quicinc.com>
Date: Tue, 23 Apr 2024 11:37:08 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/7] wifi: cfg80211/mac80211: add support for HE BSS color
 handling with Multi-Link Operation
Content-Language: en-US
To: Johannes Berg <johannes@sipsolutions.net>,
        Aditya Kumar Singh
	<quic_adisi@quicinc.com>
CC: <linux-wireless@vger.kernel.org>
References: <20240416045943.576656-1-quic_adisi@quicinc.com>
 <e4184e8fb0cd4573564ed8daace08c432757399e.camel@sipsolutions.net>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <e4184e8fb0cd4573564ed8daace08c432757399e.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 4/19/2024 2:12 AM, Johannes Berg wrote:
> Sparse complains on these patches. I think everyone at QCA should be
> able to *consistently* run that.
> 
> Jeff, do you really have no internal processes, it all depends on people
> running checks manually? We have our own internal tree first, where CI
> enforces a whole bunch of things, and *then* we send patches out.

We are trying to get there but, as the community knows, Qualcomm has
historically had a "downstream first" mentality, so all of our automation is
built around that.

The good news is that there has recently been a massive shift in philosophy
(and one reason why after many years of working on the downstream Android
driver I moved to the upstream driver).

At Linaro Connect 2023
(<https://www.qualcomm.com/developer/blog/2023/06/highlights-linaro-connect-2023>)
Leendert van Doorn, SVP of Engineering, announced "Qualcomm is about to adopt
a developer first strategy" and "embrace open source and its upstream
contribution model."

So more resources are being directed at upstream, including updating CI to
support that.

In the meantime, in my personal semi-automated review workflow I run sparse
via ath1*k-check, but unfortunately that only looks in
drivers/net/wireless/ath/ath1*k. I have now updated my workflow to check all
of the files that are modified by a given patchset, and that flagged:

net/mac80211/cfg.c:4847:1: warning: context imbalance in
'ieee80211_obss_color_collision_notify' - different lock contexts for basic block

So hopefully in the future I'll catch issues like these internally, before
they escape into public.

/jeff