Received-SPF: pass (google.com: domain of linux-wireless+bounces-6736-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <76b20f4054876cd70fb31e4b31c9653ccfe29a08.camel@sipsolutions.net>
Subject: Re: [PATCH v2 6/7] wifi: mac80211: add support to call color_change
 and OBSS collision on a link
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Aditya Kumar Singh
	 <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Tue, 23 Apr 2024 20:50:59 +0200
In-Reply-To: <ca17a2f0-eb18-487a-8c5d-811748f2ca00@quicinc.com>
References: <20240422053412.2024075-1-quic_adisi@quicinc.com>
	 <20240422053412.2024075-7-quic_adisi@quicinc.com>
	 <ca17a2f0-eb18-487a-8c5d-811748f2ca00@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-04-23 at 11:46 -0700, Jeff Johnson wrote:
>=20
> Johannes, how do you feel about the new cleanup.h functionality? I ask be=
cause
> if we change this to just be:
>=20
> 	guard(rcu)();
>=20
> then we can remove all of the explicit rcu_read_unlock() calls --
> rcu_read_unlock() will be called automatically when the function goes out=
 of
> scope.

Sounds like a good idea to me.

Jakub doesn't like it so much, see this thread:
https://lore.kernel.org/netdev/20240325223905.100979-5-johannes@sipsolution=
s.net/

But ultimately I don't think he'll stop us from doing it here,
especially if we use it carefully enough that we actually do need the
guard for the whole scope.

johannes