Received-SPF: pass (google.com: domain of linux-wireless+bounces-6737-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7587ecfc-e580-488f-b74e-20e2c115df93@quicinc.com>
Date: Tue, 23 Apr 2024 12:12:32 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS
 numbers
Content-Language: en-US
To: Allen Ye <allen.ye@mediatek.com>, <linux-wireless@vger.kernel.org>
CC: Johannes Berg <johannes.berg@intel.com>, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Evelyn Tsai
	<evelyn.tsai@mediatek.com>,
        Money Wang <money.wang@mediatek.com>,
        <linux-mediatek@lists.infradead.org>
References: <20231208063820.25983-1-allen.ye@mediatek.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20231208063820.25983-1-allen.ye@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 12/7/2023 10:38 PM, Allen Ye wrote:
> The cnt member in mbssid is the count of total number of MBSSID elements
> instead of BSSID. Therefore, we fix this by reading the MaxBSSID Indicator
> field directly.

Commit text is much more readable if you somewhat follow the guidance:
Describe what the current code does.
Describe the problem with the current code.
Describe how to modify the code to fix the problem.

And write this at a high enough level that a manager can understand :)