Received-SPF: pass (google.com: domain of linux-wireless+bounces-6760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [EXT] [PATCH v10 0/2] wifi: mwifiex: add code to support host
 mlme
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <PA4PR04MB96389E67F826216C44FE19FFD1112@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date: Wed, 24 Apr 2024 10:11:10 +0200
Cc: Brian Norris <briannorris@chromium.org>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 LKML <linux-kernel@vger.kernel.org>,
 Kalle Valo <kvalo@kernel.org>,
 "francesco@dolcini.it" <francesco@dolcini.it>,
 Pete Hsieh <tsung-hsien.hsieh@nxp.com>,
 "rafael.beims" <rafael.beims@toradex.com>,
 Francesco Dolcini <francesco.dolcini@toradex.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C8F76484-1359-437B-85BF-C646A21F7BCE@holtmann.org>
References: <20240418060626.431202-1-yu-hao.lin@nxp.com>
 <0ED16BAB-6E7D-487C-BBCA-E63FEF37C60D@holtmann.org>
 <PA4PR04MB963815B9FDA6119683A28CADD10E2@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <6CB59E09-F34E-4986-AA88-8EC4EE5E71DF@holtmann.org>
 <PA4PR04MB9638B62BC25F773C6922A4BCD10D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZiLlPOvKlfCySZwF@google.com>
 <PA4PR04MB96383D46C1187C237DFC7988D1122@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <PA4PR04MB96389E67F826216C44FE19FFD1112@PA4PR04MB9638.eurprd04.prod.outlook.com>
To: David Lin <yu-hao.lin@nxp.com>

Hi David,

> Johannes agreed that cfg80211 is the correct way for the development =
of mwifiex
> (mac80211 can't offload association process to driver/FW).

that was never my question here.

> This patch is used to fully leverage SME of wpa_supplicant and hostapd =
which can complete the missing WPA3 feature of mwifiex.
> The patch series had been reviewed and discussed. It looks like there =
is no more comments for patch v10.
> I wonder can patch v10 be accepted by you?

If your hardware is a FullMac hardware then what is the point in now =
separating
auth/assoc out. Is this done just for WPA3 or also for WPA2/WPA1. Are =
you no
longer a FullMac hardware?

You keep saying that you just want to support WPA3 and if previously the =
HW
worked as FullMac hardware, then external_auth should be the way to go =
for
having SAE handled by wpa_supplicant (or iwd for that matter).

Now if you are fully embracing to auth/assoc and we can remove the =
support
for the connect ops, then lets do it. However I don=E2=80=99t see =
anything properly
described in the commit message. You keep saying WPA3 support and =
nothing
else explain what the new Key V2 API of the firmware would do.

Regards

Marcel