Received-SPF: pass (google.com: domain of linux-wireless+bounces-6804-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>
CC: "leit@meta.com" <leit@meta.com>,
        "open list:REALTEK WIRELESS DRIVER
 (rtw89)" <linux-wireless@vger.kernel.org>,
        open list
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH wireless] wifi: rtw89: Un-embed dummy device
Thread-Topic: [PATCH wireless] wifi: rtw89: Un-embed dummy device
Thread-Index: AQHalnSYD4Tb/iMnEk2tnRSMUSm6/rF4e3YA
Date: Thu, 25 Apr 2024 05:52:54 +0000
Message-ID: <f46ae94488d1468e9a9a669320e4cfb9@realtek.com>
References: <20240424182351.3936556-1-leitao@debian.org>
In-Reply-To: <20240424182351.3936556-1-leitao@debian.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Breno Leitao <leitao@debian.org> wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>=20
> Un-embed the net_device from the private struct by converting it
> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> helper to allocate and initialize dummy devices.
>=20
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>=20
> Signed-off-by: Breno Leitao <leitao@debian.org>

I think this patch should go via net-next tree, because wireless-next tree
doesn't have patch of dummy devices yet.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/core.c | 11 ++++++++---
>  drivers/net/wireless/realtek/rtw89/core.h |  4 ++--
>  drivers/net/wireless/realtek/rtw89/pci.c  |  6 +++++-
>  3 files changed, 15 insertions(+), 6 deletions(-)
>=20
> PS: This is compile-tested only due to lack of hardware.

I picked this patch to local net-next tree, and tested on RTL8852BE, RTL885=
2C
and RTL8922AE.

Tested-by: Ping-Ke Shih <pkshih@realtek.com>