Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp893101lqd; Wed, 24 Apr 2024 22:57:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWY8t7j7pyaibgHMHmfd5xtS/DhyUM5kspdQsT4SgDmI7JI0kCMA7iD9VU8SVT1y4Fxtu+kz7Fzea1urolUWTqmDCFUgOX1zaBumlNy0g== X-Google-Smtp-Source: AGHT+IHQ++FHLqoc68/B86XtCI9h99+/5407rTyqNBWWZDu72MEjAbnhOeUWgnJBM0u9bwyXO9I9 X-Received: by 2002:a05:6358:2510:b0:186:349:58e3 with SMTP id m16-20020a056358251000b00186034958e3mr4570930rwb.7.1714024629105; Wed, 24 Apr 2024 22:57:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714024629; cv=pass; d=google.com; s=arc-20160816; b=w7Z6PrWSOGBo2ZB7ZOYuShZuglVXzas4TvScnTcplYVo8rItukRQCvgTttG31+TZYR eZ3cFZtILDxfjKi8ftFBnPGmpcwh71TF6oLz9uGaF+DXzOZfetCMOUOTHbG1+020W+n3 KXkIhpitmnNntad0HIKqfuO5wKjUYm/cbMYojtSgurlNcQ/e4UXru4M0GsrMKs3fNt9V BoOTnbONXgehcr260ywx0o5RnnhCIu9NOlXwNR1qyXgXdsdzI2/4SCJpmHwgBTlJd7g/ 7NidLhLoS4tfjrulDXFwXFiFMS/p2FnqB3mMkoeIz+q+lHeJo/Dw+9l8SB7adzpwkD3K Ttjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=F4I5OmobYHi2486e7Ar9saVx11mu8xK1/AZC3bYTai4=; fh=B02157PWJ6FsOOBtPEZPaQi+HpCs808SnlJQie2sorY=; b=Cjsit1CY+aeXb2ApZ3+7qYKOdRjfKIch1GjxP0CWJ177hF7cYjojyK2kyZcT94z8zj thUosgiJuO5rkaioWfra1v8W6ykTugv5tww4+O2QUSpOIVhNOO9xWUtoA8gqT4d2IlLv uASXbZ6h+NfOkaSyFJUGbcfNCJlhGQnP89RaFJlbvGJk3wIBdR3NRE8Ajn6CVheIxk0W WC7MMj/ahQQSCa6eSofeicJ0ZM6V2YoPK+mGP5eJMBI0kr1pTYgn4C3EQ87ruoCdlhzl l/v8P9/yAwifvhiRNiVe7H5lwl52PGPAizNNfiRhefj/C9oIvNuvMsWWOss0GSE3o3P0 W7aw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YAY7Zvxk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6805-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6805-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e1-20020a635441000000b005dc16b88e8dsi12374645pgm.353.2024.04.24.22.57.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 22:57:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6805-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YAY7Zvxk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-6805-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6805-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B21C4282C2E for ; Thu, 25 Apr 2024 05:57:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B91C740862; Thu, 25 Apr 2024 05:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YAY7Zvxk" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B11740849; Thu, 25 Apr 2024 05:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714024623; cv=none; b=DpzAj7ZB5F24+TADdQumKKFCcLmkQPYgu29kdcZnVej+0b9aay6cn4YhTHGsHT3mgdQR7kWJPtqNMumD52DEmhJmg/KSdg7Ij9TbzQ4l98BJwGXj1vCbIINcYnmXBTo10sSZeQjX8rCOeNp/ukScjzLsIVdx1MNGLULveYNMAMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714024623; c=relaxed/simple; bh=G4XtPW3jY3Xj7+1bRtRJS8FXcQOSnJLmCbUNts5ux6U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=XuHvjo6S6NvdGDStxyRNqAT26tPolISsIWrTCdC43vjUa7trIm69PatWsRcp+DR4zzwYC/I4cdAWWJ9bDaRJX8+gmttHU4FDZ8MaXMxr4EaG/7hIWyrsSVAtjp+Owhc9xHORj4Q3p16+czyEaqQ6CGPB8Va7gPrndHjBUzCFtV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YAY7Zvxk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B808C113CC; Thu, 25 Apr 2024 05:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714024623; bh=G4XtPW3jY3Xj7+1bRtRJS8FXcQOSnJLmCbUNts5ux6U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YAY7Zvxk8S/WoU2wM0qBHK8T3M6ayHnC7ch5Nfcc0JAJ3Znsqi/6C13DTBM+qQhyt 8MuWoAD+uNwayyLVxPs+STFaeHiEyG/3GUAXl+NXW3IEIbUKXqg6+GB9kroDwBNgHz MrJraNsVWM+dtS2ugTIq0qYOjYVT9o0CdX6w1GglNW3eLK+eSzlFX10Q6GVMsk9h7s tVNRJfXBjTucwlYw0d5XsRKuwDRflCxkf6Fk47ltGiT9jACjVL0TMLpPEJvwoA4iKp r/UJW7D2pmYSh5OOnu2X2BvMSptS6B0HeEJ2T2xyE5hkkJd+8UUuBq4C3v0S2xarDR PW1NTEQMChOFQ== From: Kalle Valo To: Ping-Ke Shih Cc: Breno Leitao , "leit@meta.com" , "open list:REALTEK WIRELESS DRIVER (rtw89)" , open list Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device References: <20240424182351.3936556-1-leitao@debian.org> Date: Thu, 25 Apr 2024 08:57:00 +0300 In-Reply-To: (Ping-Ke Shih's message of "Thu, 25 Apr 2024 05:52:54 +0000") Message-ID: <87ttjqgf2r.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ping-Ke Shih writes: > Breno Leitao wrote: >> Embedding net_device into structures prohibits the usage of flexible >> arrays in the net_device structure. For more details, see the discussion >> at [1]. >> >> Un-embed the net_device from the private struct by converting it >> into a pointer. Then use the leverage the new alloc_netdev_dummy() >> helper to allocate and initialize dummy devices. >> >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ >> >> Signed-off-by: Breno Leitao > > I think this patch should go via net-next tree, because wireless-next tree > doesn't have patch of dummy devices yet. > > Acked-by: Ping-Ke Shih FWIW I sent the wireless-next pull request yesterday and once it pulled we will fast forward wireless-next to latest net-next. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches