Received-SPF: pass (google.com: domain of linux-wireless+bounces-6900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <034950cb-cf04-443f-a13c-b7d7a47ff0d7@quicinc.com>
Date: Thu, 25 Apr 2024 15:40:04 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 02/10] wifi: ath12k: push HE MU-MIMO params from
 hostapd to hardware
Content-Language: en-US
To: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
        <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>, Muna Sinada <quic_msinada@quicinc.com>
References: <20240424201959.935-1-quic_pradeepc@quicinc.com>
 <20240424201959.935-3-quic_pradeepc@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240424201959.935-3-quic_pradeepc@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote:
> Currently, only the HE IE in management frames is updated with
> respect to MU-MIMO configurations, but this change is not
> reflected in the hardware. Add support to propagate MU-MIMO
> configurations to the hardware as well.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Co-developed-by: Muna Sinada <quic_msinada@quicinc.com>
> Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/mac.c | 214 +++++++++++++++++---------
>  drivers/net/wireless/ath/ath12k/mac.h |  15 ++
>  drivers/net/wireless/ath/ath12k/wmi.h |  28 +---
>  3 files changed, 155 insertions(+), 102 deletions(-)
> 

[...]

>  static void ath12k_bss_assoc(struct ath12k *ar,
>  			     struct ath12k_vif *arvif,
>  			     struct ieee80211_bss_conf *bss_conf)

drivers/net/wireless/ath/ath12k/mac.c:2816:13: warning: context imbalance in 'ath12k_bss_assoc' - wrong count at exit

see reason below

>  {
>  	struct ieee80211_vif *vif = arvif->vif;
>  	struct ath12k_wmi_peer_assoc_arg peer_arg;
> +	struct ieee80211_sta_he_cap he_cap;
>  	struct ieee80211_sta *ap_sta;
>  	struct ath12k_peer *peer;
>  	bool is_auth = false;
> +	u32 hemode = 0;
>  	int ret;
>  
>  	lockdep_assert_held(&ar->conf_mutex);
> @@ -2556,8 +2660,28 @@ static void ath12k_bss_assoc(struct ath12k *ar,
>  
>  	ath12k_peer_assoc_prepare(ar, vif, ap_sta, &peer_arg, false);
>  
> +	/* he_cap here is updated at assoc success for sta mode only */
> +	he_cap = ap_sta->deflink.he_cap;
> +
> +	/* ap_sta->deflink.he_cap must be protected by rcu_read_lock */
> +	ret = ath12k_mac_vif_recalc_sta_he_txbf(ar, vif, &he_cap, &hemode);
> +	if (ret) {
> +		ath12k_warn(ar->ab, "failed to recalc he txbf for vdev %i on bss %pM: %d\n",
> +			    arvif->vdev_id, bss_conf->bssid, ret);
> +		return;

bad return within rcu_read_lock() critical section

> +	}
> +
>  	rcu_read_unlock();
>