Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1432070lqd; Thu, 25 Apr 2024 15:56:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUXairNKCU2Ao3gjfDIImd8WNs038ZI/yNRssOnuSvULE7w5tHQVlcKkdh3ZkwnM5GdBrgI2nWXKTLTNRv1lp1hbrWNtz/NkT83s+f6Yg== X-Google-Smtp-Source: AGHT+IHrKwI4+6AZ0JZya9p5CUB84PWWQIT7LPWJ1tmgY3poxwGvVdSsUaHBqCW3z6Plpo+gzQVG X-Received: by 2002:a17:90b:1d01:b0:2af:4a3f:df62 with SMTP id on1-20020a17090b1d0100b002af4a3fdf62mr1148139pjb.6.1714085790406; Thu, 25 Apr 2024 15:56:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714085790; cv=pass; d=google.com; s=arc-20160816; b=tk5gSwn6RAn2VVV/lHLYedCaPPqsbE+ue1lc3maqEM9lI4RQG9mA4YDKQi9RMEDzxA z/nl5l7WR7Z1mKWqUrJ2Nc4LPQhlAx3kdnv3bycUbp8w8gy2UUg3HTfWQcOsJCC/UT8v F0p3CNDfJM99F7iivrwfxmUxwwhJxG+u5RCqtPY+92Jn664q3OyfVULOxIl64/JWkV14 ACeIqmGdcA7SHmEqZ1OJfeRqxIOGvNLzvCEfdjQM3/r02+oJimtWMURugzez4wSWU5eK PfWWQpd8XuzgVHlnGUUslGtCDBEKJubdjH3yf/+Sj9xkavaHjIlfx1SXsgX+8kQAK037 1R4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=pa8CAObovv7DlxdzxgZvaYmcT5+YmXfpB+xjLVohJ6o=; fh=ZJd1Cv0f1FnFBW3x7HWVT6b/r//XzdmWo65rIkKPaf8=; b=WMrvTcqfSLDAIO0eieh1ZdM2vCQ5Qi+/YNB63YxB+4pIzPot1GjRYGrBsZjU8mb0CS B5eHrxY1Lq1HiiqRMHyhQ15YFZzDWKWybrFqk/D0M3qH/3aitjLIv0eGFPjum/9FeZt4 BbuvFZDYsnfPMTt1jSa1CBNDKAH15xV/ORBBC9zJzAzJxr0nQ6KSxJPgaaHNK2H0HjfD SG3c9eahN6Istv6u5jpz5Qn3R9My4IwekaSsrhmxrvRWp/e7FVJLlw+Z6yj2I37LPWDM ezMutCLir4rLmY8ZY3DDWTbEv1Yt4mjAxLz75yE5Da8wzxcfg0EpVCZRicbLiURWy65f xkbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cV3J48dV; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-6899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h8-20020a170902f54800b001e445481862si14335641plf.78.2024.04.25.15.56.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 15:56:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cV3J48dV; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-6899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7158BB20FE6 for ; Thu, 25 Apr 2024 22:32:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04A043EA9B; Thu, 25 Apr 2024 22:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="cV3J48dV" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494332599 for ; Thu, 25 Apr 2024 22:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714084341; cv=none; b=joC6Fcl/gpT1IamN2FUF3dwvhEOfqkXOOtOPt8w2D7FhCmJc+0j2ykKfiU80zfnEytq0SE4jrlZqktFpV6NGPDtsZpeYPe2qA0qXEpofgabn2GOjXf5MLiSOREdgQLjVjtTGSmeiFYoOU0jHGBUR9MTrJBCUWMsalvyV1VzKiRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714084341; c=relaxed/simple; bh=gOOpxgP6bRuNwtm1B7qA9A2X3ZaNMok0a+1AnuAj55w=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=P41sGe59HZFDd18KEGy1I0GwtCYWAxwIjV+RfIiLKP7e4e2lSfvzF/ZEIj45jlApw7nQu/drE2aSO3dQOI4WUgdSHZWPz52OK2bmeMyFqK/a8jJ8gt9SnzepYvfZTez9Kq19g3KUu+FKLhsyLS5VxOdiLyt6/sfAHSLph/cPwRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=cV3J48dV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43PIlIrv024808; Thu, 25 Apr 2024 22:32:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=pa8CAObovv7DlxdzxgZvaYmcT5+YmXfpB+xjLVohJ6o=; b=cV 3J48dVhy3ZSvm51z3/BNbhOnVF5JCtY/qXYSEDutcTNJlE8pfDoScORE/WLIm6Ni 5iYzt5QuwK7m+ODc16jIUllmcH+Djv6IpJL1xmXYxWYsV8EVAVhwpySa8GZ2jUH9 w+4yUYuo9FFVlPksEa2EABq77ICAD7j0R+fmtJb3tQoFeg4JBvxwECiCGNgzb5o8 6uVmW7a82SUdiFDTXw74gizm9rcd4tUL9TGG6vQs+jUVoZaJ/1VEKa5dfefqz6l5 suXioiCrb6KF1hg9TwYtwV9yS0KxuaGkQNuTKqXib01YD+8j++IeemMBc29zxyEn 5xjYAGIdmh/okS+Amo1Q== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xqenkkud3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 22:32:16 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43PMWFn8032438 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 22:32:15 GMT Received: from [10.110.61.159] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 25 Apr 2024 15:32:15 -0700 Message-ID: <72bc6772-8bf7-427d-8f03-01e8dbf30d0c@quicinc.com> Date: Thu, 25 Apr 2024 15:32:14 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] wifi: ath12k: add support for setting fixed HE rate/GI/LTF Content-Language: en-US To: Pradeep Kumar Chitrapu , CC: , Muna Sinada References: <20240424201959.935-1-quic_pradeepc@quicinc.com> <20240424201959.935-8-quic_pradeepc@quicinc.com> From: Jeff Johnson In-Reply-To: <20240424201959.935-8-quic_pradeepc@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: rI3qjjRdKnAl7cpUDn3SXvuIK9uwXdeH X-Proofpoint-GUID: rI3qjjRdKnAl7cpUDn3SXvuIK9uwXdeH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_21,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404250165 On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote: > Add support to set fixed HE rate/GI/LTF values using nl80211. > Reuse parts of the existing code path already used for HT/VHT > to implement the new helpers symmetrically, similar to how > HT/VHT is handled. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Co-developed-by: Muna Sinada > Signed-off-by: Muna Sinada > Signed-off-by: Pradeep Kumar Chitrapu > --- [...] > @@ -7753,7 +8034,20 @@ ath12k_mac_bitrate_mask_get_single_nss(struct ath12k *ar, > return false; > } > > - if (ht_nss_mask != vht_nss_mask) > + he_mcs_map = le16_to_cpu(ath12k_mac_get_tx_mcs_map(&sband->iftype_data->he_cap)); drivers/net/wireless/ath/ath12k/mac.c:8041:22: warning: incorrect type in argument 1 (different address spaces) drivers/net/wireless/ath/ath12k/mac.c:8041:22: expected struct ieee80211_sta_he_cap const *he_cap drivers/net/wireless/ath/ath12k/mac.c:8041:22: got struct ieee80211_sta_he_cap const [noderef] __iftype_data *