Received-SPF: pass (google.com: domain of linux-wireless+bounces-6914-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Kalle Valo <kvalo@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
  linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org,
  syzkaller-bugs@googlegroups.com,  lvc-project@linuxtesting.org,
  syzbot+0ae4804973be759fa420@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] wifi: carl9170: add a proper sanity check for endpoints
References: <20240422183355.3785-1-n.zhandarovich@fintech.ru>
	<ccbdc170-149d-442c-8167-2b05c8cf93b2@gmail.com>
Date: Fri, 26 Apr 2024 07:58:58 +0300
In-Reply-To: <ccbdc170-149d-442c-8167-2b05c8cf93b2@gmail.com> (Christian
	Lamparter's message of "Thu, 25 Apr 2024 22:37:04 +0200")
Message-ID: <8734r8sorx.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Christian Lamparter <chunkeey@gmail.com> writes:

> On 4/22/24 8:33 PM, Nikita Zhandarovich wrote:
>> Syzkaller reports [1] hitting a warning which is caused by presence
>> of a wrong endpoint type at the URB sumbitting stage. While there
>> was a check for a specific 4th endpoint, since it can switch types
>> between bulk and interrupt, other endpoints are trusted implicitly.
>> Similar warning is triggered in a couple of other syzbot issues [2].
>> Fix the issue by doing a comprehensive check of all endpoints
>> taking into account difference between high- and full-speed
>> configuration.
>> This patch has not been tested on real hardware.
>
> Oh, I've tested the original patch on real hardware ;). You can remove that line.

BTW I can remove that line, no need to resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches