Received-SPF: pass (google.com: domain of linux-wireless+bounces-6955-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes
Thread-Topic: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes
Thread-Index: AQHal+TKjpgPPiYrQUiGyEHZzIn5BLF+gaLg
Date: Mon, 29 Apr 2024 02:08:04 +0000
Message-ID: <76b9ba19dd4642ed98975e62bc3ebca4@realtek.com>
References: <20240426141939.3881678-1-kvalo@kernel.org>
In-Reply-To: <20240426141939.3881678-1-kvalo@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Kalle Valo <kvalo@kernel.org> wrote:
> I noticed by random that rtl8xxxu includes linux/wireless.h even though i=
t
> doesn't need it. While investigating a bit more I found even more unused
> include files:
>=20
> #include <linux/init.h>
> #include <linux/sched.h>
> #include <linux/ethtool.h>
>=20
> It looks like that the includes are just copied to every file without che=
cking
> if the file really needs the include. So more includes could be removed b=
ut
> that would need more careful analysis per each file.

I can do that. My ways will be to create an empty (new) C file to examine
every driver's header file can be included individually, and then try-and-e=
rror
to remove includes from existing C files.=20

However, this driver uses #ifdef. I will check if autoconf.h is included.

>=20
> No functional changes, compile tested only.
>=20
> Signed-off-by: Kalle Valo <kvalo@kernel.org>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>