Received-SPF: pass (google.com: domain of linux-wireless+bounces-6958-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes
Thread-Topic: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes
Thread-Index: AQHal+TKjpgPPiYrQUiGyEHZzIn5BLF+gaLggAAORjA=
Date: Mon, 29 Apr 2024 02:54:55 +0000
Message-ID: <2a9fdafb5b5843c58cb080f8933b1e0a@realtek.com>
References: <20240426141939.3881678-1-kvalo@kernel.org> 
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Ping-Ke Shih wrote:
> Kalle Valo <kvalo@kernel.org> wrote:
> > I noticed by random that rtl8xxxu includes linux/wireless.h even though=
 it
> > doesn't need it. While investigating a bit more I found even more unuse=
d
> > include files:
> >
> > #include <linux/init.h>
> > #include <linux/sched.h>
> > #include <linux/ethtool.h>
> >
> > It looks like that the includes are just copied to every file without c=
hecking
> > if the file really needs the include. So more includes could be removed=
 but
> > that would need more careful analysis per each file.
>=20
> I can do that. My ways will be to create an empty (new) C file to examine
> every driver's header file can be included individually, and then try-and=
-error
> to remove includes from existing C files.

I made a patch [1] followed above ways based on these two patches.

>=20
> However, this driver uses #ifdef. I will check if autoconf.h is included.

Make script of kernel will automatically include include/linux/kconfig.h, s=
o
I didn't need extra works for #ifdef.

[1] https://lore.kernel.org/linux-wireless/20240429024711.30992-1-pkshih@re=
altek.com/T/#u