Received-SPF: pass (google.com: domain of linux-wireless+bounces-6984-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2c7b4eb9-9666-4a98-9e43-cc8ffbfc3a8a@quicinc.com>
Date: Mon, 29 Apr 2024 17:22:47 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: ath12k: drop failed transmitted frames from metric
 calculation.
To: Kalle Valo <kvalo@kernel.org>
CC: Nicolas Escande <nico.escande@gmail.com>, <ath12k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>
References: <20240419170314.3117623-1-quic_kathirve@quicinc.com>
 <D0QHV8UV73N5.2N5E3MH37JQW7@gmail.com>
 <f4c65f7e-ccc7-4a0b-a6e8-df56d5c19d7f@quicinc.com>
 <874jbsv2hz.fsf@kernel.org>
Content-Language: en-US
From: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
In-Reply-To: <874jbsv2hz.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 4/23/2024 3:12 PM, Kalle Valo wrote:
> Karthikeyan Kathirvel <quic_kathirve@quicinc.com> writes:
> 
>> On 4/22/2024 1:35 PM, Nicolas Escande wrote:
>>> On Fri Apr 19, 2024 at 7:03 PM CEST, Karthikeyan Kathirvel wrote:
>>>
>>>> +	case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_MPDU:
>>>> +	case HAL_WBM_TQM_REL_REASON_DROP_THRESHOLD:
>>>> +	case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_AGED_FRAMES:
>>>> +		/* The failure status is due to internal firmware tx failure
>>>> +		 * hence drop the frame do not update the status of frame to
>>>> +		 * the upper layer
>>>> +		 */
>>>> +		dev_kfree_skb_any(msdu);
>>>
>>> Shouldn't this be ieee80211_free_txskb ? I'm not clear when to use
>>> which.
>>
>> Yes, there is an internal patch is in pipeline, that will take care of
>> addressing all dev_kfree_skb_any() to ieee80211_free_txskb() in
>> ath12k_dp_tx_complete_msdu(), this patch doesn't take care of that.
> 
> Let's not add new bugs knowingly. Please fix this patch to use
> ieee80211_free_txskb(), that is much more reliable than waiting for some
> other patch.
> 
Have addressed Nicolas comment(replaced dev_kfree_skb_any() with 
ieee80211_free_txskb()) in latest version "[PATCH v3 0/2] wifi: ath12k: 
drop failed transmitted frames from metric calculation"