Received-SPF: pass (google.com: domain of linux-wireless+bounces-6988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes
References: <20240426141939.3881678-1-kvalo@kernel.org>
	<2a9fdafb5b5843c58cb080f8933b1e0a@realtek.com>
Date: Mon, 29 Apr 2024 15:23:04 +0300
In-Reply-To: <2a9fdafb5b5843c58cb080f8933b1e0a@realtek.com> (Ping-Ke Shih's
	message of "Mon, 29 Apr 2024 02:54:55 +0000")
Message-ID: <87frv4fjdj.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ping-Ke Shih <pkshih@realtek.com> writes:

> Ping-Ke Shih wrote:
>> Kalle Valo <kvalo@kernel.org> wrote:
>> > I noticed by random that rtl8xxxu includes linux/wireless.h even though it
>> > doesn't need it. While investigating a bit more I found even more unused
>> > include files:
>> >
>> > #include <linux/init.h>
>> > #include <linux/sched.h>
>> > #include <linux/ethtool.h>
>> >
>> > It looks like that the includes are just copied to every file without checking
>> > if the file really needs the include. So more includes could be removed but
>> > that would need more careful analysis per each file.
>> 
>> I can do that. My ways will be to create an empty (new) C file to examine
>> every driver's header file can be included individually, and then try-and-error
>> to remove includes from existing C files.
>
> I made a patch [1] followed above ways based on these two patches.

Excellent, thanks Ping.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches