Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1558627lqa; Mon, 29 Apr 2024 11:51:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWnQXDFMi5f4Zg/5Z3L9yYpWlhnUBrHnpGLShNQiB1Qcfhyz3Ogcbw4fgE2kJzxLjYvN1Muar5lmZ1ZG2B9EEfTx0IolOvmLDlwEv7Vyg== X-Google-Smtp-Source: AGHT+IEMjaVRQmASnGuWPVCNlZqvtM4IBqDuPnQIIM6zZOPLHjyWMRxYeJ6Ryb4shzQpioxLOyvp X-Received: by 2002:a05:6358:797:b0:186:9d05:5f0 with SMTP id n23-20020a056358079700b001869d0505f0mr13623543rwj.22.1714416700040; Mon, 29 Apr 2024 11:51:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714416699; cv=pass; d=google.com; s=arc-20160816; b=YR42g7KV5MptnWzsH7JEC3h9Alh/n92FXmAN/2YwZ0/QiVE+xYprZsoRmcgvdsguBV hHTAtdLc72e3+c3uQkqnAPrj1IIJkl1YzdC4e0UVmeyAvmMfLEoevMvQ2G0jDKFsDhxp aK538RbBks1GmKXLa4yu5V4gSkS2c65twXs5xPDp3hlN7EpQljHgf95t9duXs0JOK+Bw kKWCvU2APst2glfiBbWW+Bj/OQCHiVDgYQGPwomlqDlNj2A9tdeN+g+mX4mhi9vS2i4z o9E7JpLGUxcohypRukw9bQP3XkjLsZ78Q5DTDxmm4ghLL96r7QLB1w6vGMXb6j7zNCf8 VAIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=JhfC0FKN1/e9C+cslhqrtC283YJ4UQDA0JWyc3sUgs0=; fh=pxqov2Ee9NHgI7q38lGC0pQ98+KvUSZCSNJJRmO1iQY=; b=asUhRTQm0EBQ+ZfF2XcUwdOw0Kf70gSNMjNbDnQAOTHRuOyGViJlOj1Fb7QKXthlye 6Cg2TvYOTwOC6cf9wVuXmU+nwsl4hQgp4GUyC8/L1IqRUm0eMk76QPJYpLxUH/+iROS1 bxPUMAB9QlsCBzMjWURAaGgXvfRDUC3tcNgFO2LRI/yPeTKA69lGwc07IXtiqWR2QsE0 qkKYMYrMO8NnF/NyvrMiS8LasP/rfpxhqTupqLFqc5R1wVP60/DUQGfaKSxQuGj2oVsY oKpCarAal1zrKWOXYbvQbXpzBKiE9v09EYLKcqzmGAn7P5ktRvGaRTk4/B44lME/1qHu JvHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=k4wVrQRk; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7004-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j32-20020a634a60000000b005d8e36d9e11si20817704pgl.149.2024.04.29.11.51.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 11:51:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=k4wVrQRk; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7004-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0188AB20E2A for ; Mon, 29 Apr 2024 18:46:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DF4E13AA31; Mon, 29 Apr 2024 18:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="k4wVrQRk" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D993913AA27 for ; Mon, 29 Apr 2024 18:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714416376; cv=none; b=WwG5VZuhTx8ZDU42PkJcmcaSg8/y0uDSxS5uaddjRpC7LKWj7gfqRZE+XqCDCtceN++hf/ZqcDcrfmDscYivP3tRlcVMNMsI+iXvERVRJ+Xd0y/pLop7ku8xwv5NNhfqmOkMQvHzNjHOPc4GKGiAHNu9O1IRWjfPwzwwEEe4MuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714416376; c=relaxed/simple; bh=cs2Pv15TqWrl1COlAIqTWJgQE68plIKJMSrjvIlqafo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=b1aIIrZ5QRaUhH6PpEaM30RJQlGLbq/LKjN6JOsrBbT3PUGvXOHsQJ7QOj05Wwk19Rorx6fj4PVSHwud+Ds/tq/cDhHUx1kzdfYLwyAugthTQCaqBb3P5caUKJ9s5LUQCXORcWKgEI4uaEMWAERtMDF1zshj0tcdpwiC5TQ8cL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=k4wVrQRk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43THqxn2025648; Mon, 29 Apr 2024 18:46:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=JhfC0FKN1/e9C+cslhqrtC283YJ4UQDA0JWyc3sUgs0=; b=k4 wVrQRkjnEmcDmZlsfxu8Y8mY01X5/gde165mm54YIV9Ct5RR1eAcTaFqum35Lq+O jjO0Tcc/supspGqOtlltj+MAYek25KQXTeZb/o/DfE3Mpgvssezn4m5cdAgN8XDO RdSpGq/fw5EiqOCeoMWQc77XslVNd5x4gA0h8KZTfKMFKFAlzcuHl5MT17Ef50Ia hmafmroxCymumV+HCMyqYZQM4lOuQjI/jxd8WCE2+JDFV2PQAx1QUyvXcVLT/SoP 4k6SCx7fUpj8jQUo7i5yTxwyxNmtzseX0HAjfm5UXDrg2nPTTiSoBKLWu6VkPNrY Zsi89nFhggjjqzNZttRA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xtaf2jh7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 18:46:10 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43TIk9QC015212 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 18:46:09 GMT Received: from [10.110.13.147] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 29 Apr 2024 11:46:09 -0700 Message-ID: Date: Mon, 29 Apr 2024 11:46:08 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] wifi: ath12k: drop failed transmitted frames from metric calculation Content-Language: en-US To: Karthikeyan Kathirvel , CC: References: <20240429114841.413901-1-quic_kathirve@quicinc.com> From: Jeff Johnson In-Reply-To: <20240429114841.413901-1-quic_kathirve@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: UozGWburqt9uSqU_56ypRCiCrQ5vzJPh X-Proofpoint-GUID: UozGWburqt9uSqU_56ypRCiCrQ5vzJPh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-29_16,2024-04-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015 adultscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404290122 On 4/29/2024 4:48 AM, Karthikeyan Kathirvel wrote: > - Use ieee80211_free_txskb() instead of dev_kfree_skb_any(). > - Drop failed transmitted frames from mesh metric calculation to avoid > false link metric averaging. > > Karthikeyan Kathirvel (1): > wifi: ath12k: drop failed transmitted frames from metric calculation. > > Sven Eckelmann (1): > wifi: ath12k: Don't drop tx_status in failure case > > drivers/net/wireless/ath/ath12k/dp_tx.c | 43 ++++++++++++++++------ > drivers/net/wireless/ath/ath12k/hal_desc.h | 22 ++++++++++- > 2 files changed, 52 insertions(+), 13 deletions(-) > > > base-commit: 363e7193eaf258fe7f04e8db560bd8a282a12cd9 'b4' is barfing on this series since you posted 3 patches instead of 2: [PATCH v3 1/2] wifi: ath12k: Don't drop tx_status in failure case [PATCH v3 1/2] wifi: ath12k: Don't drop tx_status when peer cannot be found [PATCH v3 2/2] wifi: ath12k: drop failed transmitted frames from metric calculation. Why are there two different 1/2 patches?