Received-SPF: pass (google.com: domain of linux-wireless+bounces-7009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ac9dc67a-8bfe-48d4-a169-99f2caca3643@quicinc.com>
Date: Mon, 29 Apr 2024 14:57:33 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCHv3 2/3] wifi: ath12k: Remove unsupported tx monitor
 handling
Content-Language: en-US
To: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>,
        <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240429072039.711706-1-quic_tamizhr@quicinc.com>
 <20240429072039.711706-3-quic_tamizhr@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240429072039.711706-3-quic_tamizhr@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 4/29/2024 12:20 AM, Tamizh Chelvam Raja wrote:
> Currently tx monitor is not supported in driver.So remove
> the tx monitor ring configuration, allocation and handling.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +----------------
>  drivers/net/wireless/ath/ath12k/dp_rx.c  | 56 ------------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.c  | 42 ------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.h  |  1 -
>  4 files changed, 1 insertion(+), 138 deletions(-)
[...]
> @@ -498,7 +487,6 @@ static void ath12k_dp_rx_pdev_srng_free(struct ath12k *ar)
>  
>  	for (i = 0; i < ab->hw_params->num_rxmda_per_pdev; i++) {
>  		ath12k_dp_srng_cleanup(ab, &dp->rxdma_mon_dst_ring[i]);
> -		ath12k_dp_srng_cleanup(ab, &dp->tx_mon_dst_ring[i]);
>  	}

ath12k-check warns:

drivers/net/wireless/ath/ath12k/dp_rx.c:488: braces {} are not necessary for
single statement blocks