Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp871021lqm; Wed, 1 May 2024 20:07:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUUl0+tepfas4gr/FTh58JObmRssbeRPGnMoJjR4bB2Fts9/tMO1Yqsb5cItFqnZ2YFXLEOCqY5DLlU/xLzMounmLYmmHVKw/BTIKFVvQ== X-Google-Smtp-Source: AGHT+IGt+ygseyBXUn1fcW+1bZNLgCsB7Sd6YpK0czG94mGrtDz0YAb+glup9fazkpdwd4srvI43 X-Received: by 2002:a05:6512:1084:b0:51e:f52c:34eb with SMTP id j4-20020a056512108400b0051ef52c34ebmr1286322lfg.51.1714619254650; Wed, 01 May 2024 20:07:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714619254; cv=pass; d=google.com; s=arc-20160816; b=KtaggyubCe3o6PrVsGkPdXF23SExsKIWH9e+CkgH3bKu6zYxo3h4Cnp7VmGAL/HUmB N50j2JmgrB0wn9DhqaUOetEBgODuRjcHf1KsmejKLqwGBQJc8q/HvWUtDI6+6N2RVFGX 3auyS3hfcCk76FhRs1Eh9iu+HtsOsn2G162oEaXiCk0ZOVXBvpRFE4s9JwY+dqIUBUVX yL+Mj4vm5zkM/SCELC3yzn2z5R88bqnDDuzM3v+whtleYqzThWcHxgyWgWzEiNo/Dkq5 8MOlXZa8TscuW5/SKF+xi1dnUqL0XkK/8NNvebjUYbcwy0hZTOwhNLKmO/OxcYczcZ53 kLSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:cc:to:from; bh=0rCoR58Lway22wpUVULmnasGIQBIbM8n8Rl+sh4Cb+Y=; fh=kMpbNZ1AYSWe3Nlt4mEjOXrWxROVn/MpJ03AYoF32F4=; b=dag9xlWcAnd2RiIpDIqTlYqDA6N8EVlYOUQiR/gbSv2v9Ta+H8kWyFIiwjW9Sa4saJ xH64TCgAAAwdEMFAMloBU/rNWSnP9ZZKYW3utknyJKLoZcJDYn6rXfEvCW+T8ehW1jyx Ki+F2/Do8sAu5T5mFDdZjRTcG90Ul5WfJCAZn5LByo0XlpKEbv21Zla6FdDs/YRT4PcS a/hWQSNAHUx9bOCnMTKaCmsbyt+j88apUI+hl1KQfShRxQ2/i1RWax+/5GJEAOYlmCd8 +r6Wkvkrx2ypij0p20tKmVL0iccAfOMYUWvUORq3iwjGlz1cVGb6PwXqY1gAZl+ryjkU teAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-7102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7102-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ay1-20020a170906d28100b00a55b2e95067si10114ejb.58.2024.05.01.20.07.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 20:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-7102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7102-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5D9121F21619 for ; Thu, 2 May 2024 03:07:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1262418054; Thu, 2 May 2024 03:07:30 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486B0175BE for ; Thu, 2 May 2024 03:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714619250; cv=none; b=HM8DIWRTwwUtRTyXdoX6u7F2UNc2XIGcNR6njT8rQTlUlCk0PUqKCWY/9I38FEK2p2nfIXG+XkcrrCeQ5acmcpmZvZM+glgltUmgCERBvTL0ZmkAe/PbPydmP9Qe65amo75vMoUNRH6qrbGAVUi8fk5fRb+BizqVv/hroe+OYCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714619250; c=relaxed/simple; bh=QvojHTVWSWM4PKpOJs3/ihDskqV+3DFUY6Owy8vnWTk=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=mm+3uyn+ZgH1SPQDLqiH+g0Tdz9jQUedo3gS1xkDkbBBIm7l4Y3Dwjh/NyjhMLZ5LgnjvY2wnLvOdaISubfSuZSGq8Zcw/IJjBu/zHJBn0QWq7Eq27JuyMgCXQ4rFLDDKHrtfz81fNokZiWuo1lAwFv2ePJw12sGG12toBEAZQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 44237GOc82055490, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 44237GOc82055490 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 May 2024 11:07:16 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 2 May 2024 11:07:16 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 2 May 2024 11:07:16 +0800 From: Ping-Ke Shih To: Kalle Valo , CC: Subject: Re: [PATCH 1/2] wifi: rtl8xxxu: remove some unused includes In-Reply-To: <20240426141939.3881678-1-kvalo@kernel.org> References: <20240426141939.3881678-1-kvalo@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: Date: Thu, 2 May 2024 11:07:16 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Kalle Valo wrote: > I noticed by random that rtl8xxxu includes linux/wireless.h even though it > doesn't need it. While investigating a bit more I found even more unused > include files: > > #include > #include > #include > > It looks like that the includes are just copied to every file without checking > if the file really needs the include. So more includes could be removed but > that would need more careful analysis per each file. > > No functional changes, compile tested only. > > Signed-off-by: Kalle Valo > Reviewed-by: Ping-Ke Shih 2 patch(es) applied to rtw-next branch of rtw.git, thanks. a890495b297b wifi: rtl8xxxu: remove some unused includes 028fa281712d wifi: rtl8xxxu: remove rtl8xxxu_ prefix from filenames --- https://github.com/pkshih/rtw.git