Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1772325lqm; Fri, 3 May 2024 06:19:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXw+GdrlMP0gTTFL56szTuJMghXpiysTCvzIeaQYOspKxkDKWrwEBCrsd4TAIBO9xZde3TXqSjLP6LSV1KtpvCsfIHOJF6efeoWzq+bSQ== X-Google-Smtp-Source: AGHT+IEN1c4Qg71KrUUchySMwmP06Kw0aSSgoSftCduyyXiermGCl0QT5Sb76a7bjuNWUpYHwuZi X-Received: by 2002:a05:6a20:ce44:b0:1aa:5aac:9d9b with SMTP id id4-20020a056a20ce4400b001aa5aac9d9bmr3024459pzb.45.1714742348122; Fri, 03 May 2024 06:19:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714742348; cv=pass; d=google.com; s=arc-20160816; b=O+RwJGjqdCmT925axE2UhmO35fZqQekTWWaZrKSM7lM5zO1wdV6MjTjv3jldxD2EQB mK/RvqQ8aqId7HgiI2glYFhWvaAjYTd8nZCGQ1xzu1LEVCk9uIoBEr0o3/gzsvHBK0W2 eXXptfZsQ7pgm6fkmhHRTqcbSe8BuvsBGLZZv8SwRLFnrSTBOD724qlyHmRZ5v+F3U+P s1e1Zm6oQQ9SSDxYalDr2dOwpVa/kuTOrrKD5Z0DdJHeEYBsIEpX1GA90seocJBproEo OP7EPs0wZTlR6cRzntBIQVZQFD7FDS5yaqr9gnEgSHdpMpfoFEroDNT9NBSQbEsJjDwU yWjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=p2nzBAOcAdSYJoQ0RR9KKeTGjGfsFmjvjfMerI1Hmm0=; fh=lG9N1SB2gPaWB5yZHNc4w1Y6kelFME7PgH/Z38fA9fA=; b=MLJTpgbDIjLzE/6gBOxJIFvbdLCy6dNCyfL2yOsPmVhy4z4XvlXbgn510h6PCCz1Ey xjcixwCZe9Hm01cbpWjZwEqj3Itp4nEMdbYGQ3mQiRQMTEmDQo5DgB/oPDWrlS0KYDQ2 /P8autD5q2d7Jbt3you9jJB71axDYx/NwyfHrbnL0b19Ct0/LfGBvX7g0LydRJBteHRA oUU2FrVmukahbQUDbbUfTpbpQ9OcYU8PNSgPinS15yE/BxiIObkLQSizMKRZ0yoe4oWk 5ejOcJDcuq67aL4XM3jwhGTNjg/WjA4gGqXnbVSbwnEOzDOQFaEJdKQeSy7PMiN7ARzE 4fdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UMgF+XHk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z186-20020a6365c3000000b005dbde399b23si2733646pgb.901.2024.05.03.06.19.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 06:19:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UMgF+XHk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BBEF528200E for ; Fri, 3 May 2024 13:19:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46353154435; Fri, 3 May 2024 13:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UMgF+XHk" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2B515442F; Fri, 3 May 2024 13:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714742130; cv=none; b=adHzu++1EwoH4JV9LkHeXzj1n84+64KdPRpdXSf7fKojbJl8tkI48BzNVgQM08z73kM5k61Lnt3BdFL1Koqu44Qg9DkpBzGJVHc6Rdez+6QDz9qZZmgiyghUiN8kzbsPj3ButMM+3mvpNPekEBh5W9AxYTTb6bE4x8cfdBzxKH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714742130; c=relaxed/simple; bh=u7OhV14b+KvvL/Ob6hW0mx28C4XmQQk3bSQXLrG+R1g=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=Fb4G9dMIPUz8HVZnrVQcvqupKJxIRhmqyGUuCsGRpAo4427kvG4dBEvZU4unuCPm8PNoVVYILQALrc9/FBeyr7rH5ELD9xyI2RiAzoVu8wvvu812sysTdDJ1w80nlx5nTy4PdzzMj2cPGi0thzHPHaajRiaCNRlpQiSPkDfW70M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UMgF+XHk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C9DC4AF1B; Fri, 3 May 2024 13:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714742129; bh=u7OhV14b+KvvL/Ob6hW0mx28C4XmQQk3bSQXLrG+R1g=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=UMgF+XHkCoWysTyGLbnNRboqoX82pBZjHq8IISsbQmKwb5+lz58zNVpq6t6zv9b8l 2yaWIOPp89LuHIkKP9PCcUmyoY59voKR9wOPjUIm87jdE0jkhrmkTkuJk12oMYV5Er ekmjuSPQrZDSCbd/TNlLNKzar9aesWO49u5WOWLBwPSu/IrF66f16F/xA5fzbVEfgU 2PyoozYi0OAdoiFeIDTI8jZdYhHyZZFqHSSakr+aZSTbhVmSC//38jPuaeUMhuHFzP 58uhFZFU67uwhluWGQnlPHpX3HcBSv288izLYJVZlg10gBh6PpeF8u9ev6/kEDJySG 5IcYCl1Jd8wIg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/2] wifi: ath11k: refactor CE remap & unmap From: Kalle Valo In-Reply-To: <20240430-ce-unmap-v1-1-e468328f95d9@quicinc.com> References: <20240430-ce-unmap-v1-1-e468328f95d9@quicinc.com> To: Jeff Johnson Cc: Jeff Johnson , , , , Jeff Johnson User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171474212652.1512332.14638586836562362719.kvalo@kernel.org> Date: Fri, 3 May 2024 13:15:28 +0000 (UTC) Jeff Johnson wrote: > Currently the logic that handles hw_params->ce_remap is inline code, > both for doing the remap and the unmap. An upcoming change needs to do > the unmap in a second place, so refactor the unmap logic into a > separate function. And although it is only called from one place, > refactor the remap logic as well to have functional symmetry. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 8b9ea752a9d6 wifi: ath11k: refactor CE remap & unmap c57d00a4d3d8 wifi: ath11k: unmap the CE in ath11k_ahb_probe() error path -- https://patchwork.kernel.org/project/linux-wireless/patch/20240430-ce-unmap-v1-1-e468328f95d9@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches