Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp455261lqh; Sat, 4 May 2024 07:48:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXsXCofsUlWvBPx0RG9xEXsbLwVwQFU5IY8K9l5lcFouSu18FmzFkymKZDxIMWymdEwm9PrDfiqW+yO2La3KoChois8nHHuhxNjhLby2w== X-Google-Smtp-Source: AGHT+IFLfywzQ9S9DbdkrgIniJxQEnbXMAF5RsXY/N3Gis358U56NptrkYd6kwVHniNB4iVkx0hZ X-Received: by 2002:a05:620a:8520:b0:790:6d09:a443 with SMTP id pe32-20020a05620a852000b007906d09a443mr5204435qkn.72.1714834095823; Sat, 04 May 2024 07:48:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714834095; cv=pass; d=google.com; s=arc-20160816; b=Ykai+heKbzr39u/WZFPiu2hRqxyn+D5zUKtcDA/P2rvHOnla2Sd9j57Ff6/j30zM1X wPW8SicRM1ob9wZqPj5OjiZmGAisFOz3y2gP+0Utlz5m/1lSalE+8XEQEUUHg0dEebma xqlrqARAHcDDsLFGW0mKfg56xTZJewAkfXzBAqu+wVYqMPj3wSzh67U6XiwvR0C/qJ3n OW09JTn7JY3k21k2gMF0mo9O6cQFMJZ0Nct5MEIXHayOHaDzdyvFQZrW5OqRhH4eSDXZ fygfBKcdr9mp5MSKSPRMG3eJ1kipfTYchXQDXCgsrZJNjxmoo5/JwFJqN5kVHuThZtME xxhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kOSEXZU6TVz8M4F2jRVhLHEeRiCfqad6916Ci1jBVnI=; fh=GsU01rxL83RXpEfOoBff4btbwnY/boHK9kl5zyazkcU=; b=uan5TE/39exKVb+CB1l5eNqwqkneINME53HyupX7mWWnp5Ozgls8tKUQ+jSLF4ZRp8 M0tcEoOM7ZqDe6NRbnr2FZkIx/rfZr+r/TZ06GK9NhqpOJQfbIiIX6A0V/UmlV7IRMKC jT7Y9mbZLtjprJte+aYvxtVWiqhvFeRj+uUik2vD9B7jW4WHS3fvALLGH7Ox+pDzXCTP eTSmkmOZEytOWCZD9SDQdXUQ19IlaENngigHK6zaudJzOjG0Nvw4zev3PVn7hvUqv3GN zAAveG0zC8DRV4ZGiYoRp+aOubLOvoqWVJwzRI7dnDgLFRf6KWzN/qiOzWX60uCA4RuV TYqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTjuRlls; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id br41-20020a05620a462900b00790ef75385csi6022982qkb.15.2024.05.04.07.48.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 07:48:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTjuRlls; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3D6771C20CB2 for ; Sat, 4 May 2024 14:48:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0E2C3BBE9; Sat, 4 May 2024 14:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OTjuRlls" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914D057CAE; Sat, 4 May 2024 14:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714834091; cv=none; b=rvJM2eUuypDmtNCQXd29CPVk6YMlZ64eiIxBvD+kEbac9Bb6NwZAdVvHhzTEQMRaZ71eQeKNM1s6vGJLrs7ic0l8Zvm0UZ4AhdFwga+lqjnOBVzWZSrzg5BJ9wxsPStMZV4Roq0MLqXm+amFieNg6pMAsmFV6ZCaq7Se5vx6JqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714834091; c=relaxed/simple; bh=mnWhwHwbu6vfOBX72yPCmIu8TRUsTLMhnSRh1zYW2oA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Du03qjVmNx+xgVTQAjNfvR+Y/k3or+GlgO25NG0imYXEYZvNXEh4IPVvo1KiB9BDFs/Xd0aM3/PS0GtvcwwAz1sMG9liGoaQQI151e9Lnh1p17+bKc7VKc4oGW3tDD+iSnPiMhQ9yDq8/X1iwea1RAg+94KZYRslEYOrjzXpXA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OTjuRlls; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A53C5C072AA; Sat, 4 May 2024 14:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714834091; bh=mnWhwHwbu6vfOBX72yPCmIu8TRUsTLMhnSRh1zYW2oA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OTjuRlls7beT4C4+N9maJy/KhaTRAZ/gauIYHdhqD3NUKTnYtw3OajltEC0pIT9Q3 sl4023iOTIxTsQWPP1MfdWABYeqxAtKeMb8BmQ7GvvSCZfn4H1PHJbTtjmMk/B/U0Q u5Swrw/b1EPQMksmhSk1Z1ySi5ejMCMWkYebAvIRFDFb+kmuf8N/nXBKcjAM47uTv6 g7U1Cd7URbGLeDlbjeTJCAey4964nkF5pi1KdumQDNlSOh3Xn4uDTasP9BJRBi8MHn Aw7HBhRiaQ8lC/1MFx2VgJYH4jBbNRgmHBKm59bNqc0JQBzWOFygzTNnlEm8op7jV0 JaVqtxT17Rz0Q== Date: Sat, 4 May 2024 15:48:07 +0100 From: Simon Horman To: Breno Leitao Cc: Kalle Valo , netdev@vger.kernel.org, merez@codeaurora.org, quic_ailizaro@quicinc.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH wireless-next] wil6210: Do not use embedded netdev in wil6210_priv Message-ID: <20240504144807.GB2279@kernel.org> References: <20240503103304.339489-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503103304.339489-1-leitao@debian.org> On Fri, May 03, 2024 at 03:32:56AM -0700, Breno Leitao wrote: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct wil6210_priv by converting it > into a pointer. Then use the leverage alloc_netdev_dummy() to allocate > the net_device object at wil_if_add(). The free of the device > occurs at wil_if_remove(). > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman