Received-SPF: pass (google.com: domain of linux-wireless+bounces-7194-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <eddcf755-361e-16ee-b21d-dd261882be98@candelatech.com>
Date: Sat, 4 May 2024 23:42:50 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 07/15] wifi: iwlwifi: mvm: consider FWs recommendation for
 EMLSR
Content-Language: en-MW
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
 johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
References: <20240505061959.825245-1-miriam.rachel.korenblit@intel.com>
 <20240505091420.2fd3387882eb.I7a8a5b24658744ed732bfc03b1872c9298483d62@changeid>
From: Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <20240505091420.2fd3387882eb.I7a8a5b24658744ed732bfc03b1872c9298483d62@changeid>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/4/24 23:19, Miri Korenblit wrote:
> FW sends a notification indicating whether activating EMLSR mode is
> recommended or not.
> Support the notification and enter EMLSR only if recommended.
> 
> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Reviewed-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   .../wireless/intel/iwlwifi/fw/api/datapath.h  |  7 ++++++
>   .../wireless/intel/iwlwifi/fw/api/mac-cfg.h   | 23 +++++++++++++++++-
>   .../net/wireless/intel/iwlwifi/mvm/mac80211.c |  3 +++
>   drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  2 ++
>   drivers/net/wireless/intel/iwlwifi/mvm/ops.c  | 24 +++++++++++++++++++
>   5 files changed, 58 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/datapath.h b/drivers/net/wireless/intel/iwlwifi/fw/api/datapath.h
> index 0f7903c5a4df..faa7b38df9e5 100644
> --- a/drivers/net/wireless/intel/iwlwifi/fw/api/datapath.h
> +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/datapath.h
> @@ -1,5 +1,6 @@
>   /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
>   /*
> + * Copyright (C) 2024 Intel Corporation
>    * Copyright (C) 2012-2014, 2018-2022 Intel Corporation
>    * Copyright (C) 2013-2015 Intel Mobile Communications GmbH
>    * Copyright (C) 2016-2017 Intel Deutschland GmbH
> @@ -89,6 +90,12 @@ enum iwl_data_path_subcmd_ids {
>   	 */
>   	SEC_KEY_CMD = 0x18,
>   
> +	/**
> +	 * @ESR_MODE_NOTIF: notification to recommend/forct a wanted esr mode,

There is a typo above 'forct'
Maybe worth fixing if you respin for other reasons.


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com