Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp44068lqh; Mon, 6 May 2024 10:40:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWb4wCLQDngVJAVuojgiU3g9OMs5LW/8h9oikZropLEOs62tvgXERW2SNthOtJlQkI3vnY9WZxYL9y/GirWxSCatL20b6k2LqTM1fJU2A== X-Google-Smtp-Source: AGHT+IGDhr55DWta8XM5Y0GdiFUl6RBc7pcSJe1fCAI/V7dgwDv8iQMnnHdiNE/QCyE2/oUToYqV X-Received: by 2002:a05:6808:2392:b0:3c9:506e:3301 with SMTP id bp18-20020a056808239200b003c9506e3301mr13284979oib.57.1715017206021; Mon, 06 May 2024 10:40:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715017205; cv=pass; d=google.com; s=arc-20160816; b=Vxe2Hy/bPr+3TAtGLYQwgKbzJJWJ/6VboXj916Ge68ubIjhm1vg6HFhhvWelEUEDeg MVj0vCmVCmElihinlrpnFY91Ef95rcXcKCfDSOz8vkyfbC4quVMEXt9W9kURCFBeo3zg SIyiPNYjHRPVuDaBIj8f5HsLs52ISLVb9CKnleyvCaB6t+A25EfEq32950cXKTxV4bdx Emj0kYNqeP7XtdkUCx1kq0zLFNfftdwq/LHZw+EYGLjZUCIMcynFIRnw99Tb+LhJ2oc3 Sg0yZU3gMaID2jzdhFqYPJ7xPznJcTauclj4DTuBpTgkOT+vLnBDgUITr7BCEwAy3xqz 4M7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=8CMMM3Q3bnHM99F+R/CBfZNdms2W8A1FK7FOk9RBH1c=; fh=hdtAoDM5HmBK2SjUfE0cHiE9KqLx0E7R6uIrGpm4Z1I=; b=HThvkFyO6LoyaCJHdvw64x/pgkAqVm0bHDfJEumVshM9BPSgTiGw9H6h5fQayRf0FS sd1WT2YHIKQlwXFyUhnDNAr/+vxK/pPW3V08dECJb9l/7HJsJlHQ3g9bbtWVbf4Ejj/G DmcHPLlk2SrKLa3SLVBKS2TlPgCTe5k+YOBDWuKBGTjnSkycUSJuLfT6bR0kgvW5f03R m6tzNkNS0xHR33NkwhA+iTaUaZe54Dryz1X406BOytKZ0NbigKUv3euu6hcFWMBgW4p/ pM8APS606LhnsjzGc4Bxm4iRqnFDppZzuFhzlXzP24XyH/eS7C2pQp5tEx/Uk3UQv0Bu dHLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=NrtdTcsM; arc=pass (i=1 spf=pass spfdomain=qualcomm.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7222-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id jt2-20020a05621427e200b006a0cb4e22e4si9630250qvb.153.2024.05.06.10.40.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 10:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7222-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=NrtdTcsM; arc=pass (i=1 spf=pass spfdomain=qualcomm.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7222-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A22FD1C20DA2 for ; Mon, 6 May 2024 17:40:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 74B02157A48; Mon, 6 May 2024 17:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="NrtdTcsM" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AE2157461 for ; Mon, 6 May 2024 17:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715017199; cv=none; b=UQ0qw8mX7LKPVNmoMANCFcaSK2zM+OrBexwugyWfDu5DWCj07uBcapo2Bnlo4bebrQAVqM0wJ9fkJRPlTm5IVsn0or6TzCN1t6LET2MisOEEkBeB2O6NPU3bY+ppNS591sl5IbqTkQwyrQHy3qa7ghdoTjGE0m7Q5M2lqXfpDbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715017199; c=relaxed/simple; bh=LBh3ETFUJzmGWEDz468gzJuAPnKf2x9oHPXyTqeqodc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=b2Q8Zt1BbBzjbMFVXVPnmgXOIva1RTqAyGQUgDqOt553JDfyHepUbfKVXYqOO0ut4CW+BcTh8saP4Y9yAFkHmoQp0vrgv7CltEVEVdeP40CvH+IdacsAJFjdGSMyB3Hfis6b/YVavCHssgq2A/yFl8ixiiGibTsYDuVQ8DvVit4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=NrtdTcsM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 446DTWdP028201; Mon, 6 May 2024 17:39:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=qcppdkim1; bh=8CMMM3Q3bnHM99F+R/CB fZNdms2W8A1FK7FOk9RBH1c=; b=NrtdTcsMyo50Ek0yP81nUBoKg4mHSq3snFTM ec9blhD4Q8LvAUIb0LDL+CNwZ7jmfTKmLdfdCHZ9LYO8gHRWD5iF5GbuKPfQU+IR FJi1Rj5wmQIiVx43LBH8CbZrMq5U3RbQ4VO/bwtM3vPUX9+M0Wr8cWUpdp6F7uEh HwVWKTo1taIE5jouXmKpqqeP9TaPKZjXoU7/4uHYn36NV0B6GT0DXaTzj2nArpQz 2o26QPX2zEDnuY6OjDw4SBlEK7fljvGjNXV/rya23nzrfedJWp4M6+kMmU4nQy+s BuI8FLUXotYStV7CBHrTf1IiZJAq4gpv79VyaEjETmvzeSbS5A== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xxw9a8y4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 17:39:53 +0000 (GMT) Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 446HdmWo009724; Mon, 6 May 2024 17:39:48 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 3xwe3k9tvm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 17:39:48 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 446HdmbE009719; Mon, 6 May 2024 17:39:48 GMT Received: from hu-devc-blr-u22-a.qualcomm.com (hu-hprem-blr.qualcomm.com [10.190.108.75]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 446HdmgD009718 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 17:39:48 +0000 Received: by hu-devc-blr-u22-a.qualcomm.com (Postfix, from userid 4146166) id 87D1A4114D; Mon, 6 May 2024 23:09:47 +0530 (+0530) From: Harshitha Prem To: ath12k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Harshitha Prem Subject: [PATCH v3 0/8] wifi: ath12k: Introduce device group abstraction Date: Mon, 6 May 2024 23:09:35 +0530 Message-Id: <20240506173943.1747037-1-quic_hprem@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: MEjtt7VICiLJj4pflqpQ5yTzfpCAWcSk X-Proofpoint-ORIG-GUID: MEjtt7VICiLJj4pflqpQ5yTzfpCAWcSk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-06_12,2024-05-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=714 spamscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2405060126 From: Harshitha Prem To support multi-link operation, multiple devices with different bands say 2 GHz or 5 GHz or 6 GHz can be combined together as a group and provide an abstraction to mac80211. Device group abstraction - when there are multiple devices that are connected by any means of communication interface between them, then these devices can be combined together as a single group using a group id to form a group abstraction. In ath12k driver, this abstraction would be named as ath12k_hw_group (ag). Please find below illustration of device group abstraction with two devices. Grouping of multiple devices (in future) +------------------------------------------------------------------------+ | +-------------------------------------+ +-------------------+ | | | +-----------+ | | +-----------+ | | +-----------+ | | | | | ar (2GHz) | | | | ar (5GHz) | | | | ar (6GHz) | | | | | +-----------+ | | +-----------+ | | +-----------+ | | | | ath12k_base (ab) | | ath12k_base (ab) | | | | (Dual band device) | | | | | +-------------------------------------+ +-------------------+ | | ath12k_hw_group (ag) based on group id | +------------------------------------------------------------------------+ Say for example, device 1 has two radios (2 GHz and 5 GHz band) and device 2 has one radio (6 GHz). In existing code - device 1 will have two hardware abstractions hw1 (2 GHz) and hw2 (5 GHz) will be registered separately to mac80211 as phy0 and phy1 respectively. Similarly, device 2 will register its hw (6GHz) as phy2 to mac80211. In future, with multi-link abstraction combination 1 - Different group id for device1 and device 2 Device 1 will create a single hardware abstraction hw1 (2 GHz and 5 GHz) and will be registered to mac80211 as phy0. similarly, device 2 will register its hardware (6 GHz) to mac80211 as phy1. combination 2 - Same group id for device1 and device 2 Both device details are combined together as a group, say group1, with single hardware abstraction of radios 2 GHz, 5 GHz and 6 GHz band details and will be registered to mac80211 as phy0. Add base infrastructure changes to add device grouping abstraction with a single device. This patch series brings the base code changes with following order: 1. Refactor existing code which would facilitate in introducing device group abstraction. 2. Create a device group abstraction during device probe. 3. Start the device group only after QMI firmware ready event is received for all the devices that are combined in the group. 4. Move the hardware abstractions (ath12k_hw - ah) from device (ath12k_base - ab) to device group abstraction (ag) as it would ease in having different combinations of group abstraction that can be registered to mac80211. v3: - Removed depends-on tag of "wifi: ath12k: Refactor the hardware recovery procedures" as it is merged to ToT - Addressed the deadlock warning seen during rmmod. v2: - Rebased to ToT Karthikeyan Periyasamy (8): wifi: ath12k: Refactor core start api wifi: ath12k: Add helpers to get or set ath12k_hw wifi: ath12k: Add ath12k_get_num_hw api wifi: ath12k: Introduce QMI firmware ready flag wifi: ath12k: move ATH12K_FLAG_REGISTERED flag set to mac_register api wifi: ath12k: Introduce device group abstraction wifi: ath12k: refactor core start based on hardware group wifi: ath12k: move ath12k_hw from per soc to group drivers/net/wireless/ath/ath12k/core.c | 433 +++++++++++++++++++++---- drivers/net/wireless/ath/ath12k/core.h | 87 ++++- drivers/net/wireless/ath/ath12k/mac.c | 108 ++++-- drivers/net/wireless/ath/ath12k/mac.h | 9 +- drivers/net/wireless/ath/ath12k/pci.c | 2 + drivers/net/wireless/ath/ath12k/qmi.c | 10 +- 6 files changed, 534 insertions(+), 115 deletions(-) base-commit: 2c4d8e19cf060744a9db466ffbaea13ab37f25ca -- 2.17.1