Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp412890lqh; Tue, 7 May 2024 03:05:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRSlBlkXr831oR/ErzR3HNcT1aqW80Xiln7T92azpg/YBXbLHNwok/HBoXNk3PGSoi54d9u7jOC8/A4v/ymmMktBPR4mZE1+NDvfy39w== X-Google-Smtp-Source: AGHT+IFZNhnJfohRAdt6wx6A9+/t/X6Iq3ctipoqf/y4kWTBxDtgQkEoYQRqHhaOhqR1hAJud/o3 X-Received: by 2002:a05:6870:ac0e:b0:23c:5194:e19d with SMTP id kw14-20020a056870ac0e00b0023c5194e19dmr15551759oab.24.1715076342945; Tue, 07 May 2024 03:05:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715076342; cv=pass; d=google.com; s=arc-20160816; b=NEcx5SWBWIeIO7E0MfDWdjp+52BxtoARYdBSuQNw+CV8viemQHNc00AaAGBmhMYryi OjXJzR1n3BtA02qcMh3KZ002l+JyrktgxVIc1/tlfGLb2iqly4YTASS+E23Uq38CgxVg Qxid4mUT4+P8aX6mbKIlFkGaFzqVmPlNgUcRIZEMgOiFPdHn7qlLxrcWJa0Wbl8KPmPG yVCLa/yCIFrnaJuNnfiR6J8DzEl5CpY2+V5AV2sCptF88ke7f2xpGIo6nfnPiFZEfKdf xGfHEtp5vcSFFQYNQWodSzt/xZ0bfKWaeFeq5u0SRDL5pkZ5RGYN8WdN67HdNr0TDrje NbnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=TrdA8wEsHPidM7LU9Kh4D0iIU/KH7oasf/6bWvFpXc0=; fh=Mk0Gye0p2hZR6qlIkeOnnFoVl6DqlysGwwnjDR/Xl9I=; b=HXKDAiZs4ZyGtcrdWsZJZ0XM6DKY9yRHIT3w5A1ANFRQR0tGWxPjRZwD+FJAUciDnU Cfzh7y+EmNcWtKkhyF8HjcwBzd4mb/Zhf2JDrtwxV5lz4booI8mM81avuje+boxIvHJM EzL5S6mXCvZwnpGDZnHNE1wjcWHQf0KccMD5+T3UIidqmQxyGI9WfsL+D1fUQ2JKgiAE iTxhUXbOVhlOuoLkZqkwrPbVaFu+tnNiyhZXbaEPio8OVuJNRYO0MyBl/wip1bXpIHyh urfgD6N/Tet3pfDDwTo8jnBSN4aUgRM2feeIC2PmZ8Gb3MV0TlJPaqe+qVA1f/heVpod 1KPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZKMXmQ0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7276-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7276-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h20-20020a635314000000b005e46e6ba6cdsi9912103pgb.391.2024.05.07.03.05.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 03:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7276-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZKMXmQ0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7276-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7276-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5EED9281F05 for ; Tue, 7 May 2024 10:05:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2159814E2F1; Tue, 7 May 2024 10:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hZKMXmQ0" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E28B414D443; Tue, 7 May 2024 10:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715076338; cv=none; b=LeDvZTVl4DbydG4EvRdCYw4KCct5RoQgczIzUZWFCFQYF+88nb1pwicOe9FGEdRWZn2tT6llfbQKEIh/5f1e6mW4F1cwPpko6lRWxpKQN3xsyXwCBhnNSJHTTt+I50gQb1k3s82sN3PL/3z5vEihMv6jyu4c+fBxnzSuyZslrmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715076338; c=relaxed/simple; bh=zVcUl3GHK4Klc1HbBXDvbpqqBLsYLjnWF6jdPaLOoDM=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=rc9BlWA0M4/XqLDbLxe2jnCGTm2di6NYN3DVQj50cbdeZcJMketZevmmAEvGslczSWwM+F5tpX2W0BO0vzl4mrMiOrDvPBacUI88jOxBKe/LtlUUS9QKBUraxPlVLXdAPcDOxw08i9VGaD6n6AZ/ChkPbdRcRv7xnEQoBXwZlrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hZKMXmQ0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22E90C2BBFC; Tue, 7 May 2024 10:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715076337; bh=zVcUl3GHK4Klc1HbBXDvbpqqBLsYLjnWF6jdPaLOoDM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=hZKMXmQ0xyHUdME97VnF04JAmb8/ELTZq8yEFt8JIrNg1+PfRZDHJ14DgvA8E73Fp 0vZt2CWocJgyqTVZm1UqzpwTn5QGVSrcFDVPb+o5uwaKNUOPa9RtF9Xv/cINgOW2hV eKqpmdlxCBE24dlcCSLI4ra/VbQkU1qqu7jqSnb4HvXL2MnMZx0W6KMIWyARwvYRVl ymyg+zfVddH8Yh4JVHB+nzxTr+eLKeaqxsRl5YDxwo+q8XBXaZdEPSPnUEhKxw08Iv Pqyh0vwVFsjJQcGxiFg4NrM5G1KoLewJ4geY7yoob6+DHgJPy5yp7+Ixxa9Xdr6MPh jcUE2m5e7fkYA== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH wireless-next] wil6210: Do not use embedded netdev in wil6210_priv From: Kalle Valo In-Reply-To: <20240503103304.339489-1-leitao@debian.org> References: <20240503103304.339489-1-leitao@debian.org> To: Breno Leitao Cc: netdev@vger.kernel.org, merez@codeaurora.org, quic_ailizaro@quicinc.com, linux-wireless@vger.kernel.org (open list:WILOCITY WIL6210 WIRELESS DRIVER), linux-kernel@vger.kernel.org (open list) User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171507633406.3818005.5416249178784551917.kvalo@kernel.org> Date: Tue, 7 May 2024 10:05:35 +0000 (UTC) Breno Leitao wrote: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct wil6210_priv by converting it > into a pointer. Then use the leverage alloc_netdev_dummy() to allocate > the net_device object at wil_if_add(). The free of the device > occurs at wil_if_remove(). > > Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1] > Signed-off-by: Breno Leitao > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 10d2b4f4aa0b wifi: wil6210: Do not use embedded netdev in wil6210_priv -- https://patchwork.kernel.org/project/linux-wireless/patch/20240503103304.339489-1-leitao@debian.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches