Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp469505lqh; Tue, 7 May 2024 05:08:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWemmc16HrxREPwNs+U9fqIK8IJnyv5xWoMszAX/Wj2uOrNGe+ZKsWYM1JWSzBsLKDT7j1yQsGm2fNhbALsVhcWD5YOx5KeX7IA6bZZkQ== X-Google-Smtp-Source: AGHT+IH7TbHxWYxm4REJr2Cic1kX4DqfsRElcSpcMCW2wk66uubVpNo37ohOS4vApNMj8mpg2Dfk X-Received: by 2002:a05:620a:a16:b0:792:9538:c0f0 with SMTP id i22-20020a05620a0a1600b007929538c0f0mr7107740qka.23.1715083713214; Tue, 07 May 2024 05:08:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715083713; cv=pass; d=google.com; s=arc-20160816; b=yBnVru1pMzQ4WaheuDGjtHoCSLr0RI4F6ukuNBsnbPHzbAXBzJdJh9cAvSYYwyLNUk 8Vja3DKlD9U71oeKWEf6hXPBStNynkqrg0WOsgjs5Y/u8BH6ctMcnSF7EkAfMKehsY9L YiPcr2koGYbbaeJvAVGjk007fwuB7zQXyDJekb7tlr5i3d6wuSJiaXEgGvn6ZQXi5KLw 3cmhNFmHcESVbJ+S90hspM4I9I8p8Y6vchGGj45/kZb0n3cF5waylP7Gmv3xSVVERup3 8FuciDzS07NN+nmBZHB9PHqCAmuxjAEG+qy53bTYcZx3uJVTD5TSD5LwgNWaCJCw+W5s lHWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Vg3wcihCapWv2Bc+6zfth4nRQqnjv6lT8f606hV2iUM=; fh=4q9Z/FaVzZbYwNgV9T4pdPJS+COweTit4kIZIU7jm2Q=; b=xc8vcbaznPk7bRkP0vjQ8ze2L/Q67UiM0dPowvvdFz9G6nFxXgiqpCarfg8woYRGWF YT9RQAyuTggnMkceumMkq9Hh6mgoGM3m09wjQE1E8hnm8epCcWGQrDTmPADkmEl/Q1Vi v34Ib5phiEVcNtUlP0htBPwE3rp4TRAAjVNu0PfVIi6y7Uz2tuK3BHjafROppcXHUZSS T/srea2QroiBUhCj4yzu/inEKbLFGuAgJWcieeN0xG4NwTzHNAeAvHW6Tudn07j4cAGP ABCLBTF+m9VdZUZPzfast4ZGaQsYMn72RiA3+jSQH740zfY6anQOsfL9z0T/kjLB2/lf bYVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eZfie1WS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7286-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7286-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id n23-20020ae9c317000000b00790fb6866e6si11196973qkg.567.2024.05.07.05.08.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 05:08:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7286-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eZfie1WS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7286-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7286-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B16A21C2203C for ; Tue, 7 May 2024 12:08:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E120156F22; Tue, 7 May 2024 12:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eZfie1WS" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C6D9156864; Tue, 7 May 2024 12:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715083708; cv=none; b=ELDIbx14FSgZMA+v97L4wsyYqtk/bTn0Njud/aqDAVHtLH4mQxvf1gPPkcRqheiUXBoHQ6TD2ak5ajKFJIEr0NLr9P0HJ6XQSPyg9iP54FP2hBjImUWC38ToeGYmfFud30Q3maAuZMVbw5RMpitZBgi+2iSHGMRyGdNaUFNsDWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715083708; c=relaxed/simple; bh=r/iiWHA20dF8NmTwth/leMkONbX7J6hLFAP3jTNvNqE=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=b8WUrKCL1pukMUFIGUwvFvdDt/6fGalcsQDbFWQ72Jkiwt6D/Ha9gkQp/rH6/O2R94QFEzLgUDUSrBwlSSM3HFLzphp7g+t1P5/5O2A3AdgJgXvSnvPd4VILjQ9/G4Uzn9aA2XRvk+kwckSQQIfQ65LpUWNuHaj/fmzxXL3uxR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eZfie1WS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DF2EC2BBFC; Tue, 7 May 2024 12:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715083707; bh=r/iiWHA20dF8NmTwth/leMkONbX7J6hLFAP3jTNvNqE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=eZfie1WSHZxOdOtv3eKO9ktleaEjiJoh7TmxPPwfOBDd67C5qLJMi0tsvnpf9Azkb cAK+wTePFHiLKWGmbWc9Al26T8M9cnMKjOkpVHylxFgVTe4ZzavrebtltHIxRqouii iNHWvuq40iJMBXJXRHLhAOQfSbmxRuwCRI6/AOg11fxAdohyer2tUe+7xaF8Vn/j4U +lRPPmZ4qh/RumPPfz3DHXyHAb1MLjYE7WXrEcGMeoyQqdn7uQdZYMANZNxFMZsXPi c2yS9hDDWEbt/giSFZHgAj0VSbwFNuws22DGhp41QryA4l/BD4k39XjWxSOhdBTAE2 Pacbvp2Rw1gVQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: mwl8k: initialize cmd->addr[] properly From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Jiri Pirko , Johannes Berg , "Gustavo A. R. Silva" , "David S. Miller" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171508370426.12731.13082451310329470582.kvalo@kernel.org> Date: Tue, 7 May 2024 12:08:25 +0000 (UTC) Dan Carpenter wrote: > This loop is supposed to copy the mac address to cmd->addr but the > i++ increment is missing so it copies everything to cmd->addr[0] and > only the last address is recorded. > > Fixes: 22bedad3ce11 ("net: convert multicast list to list_head") > Signed-off-by: Dan Carpenter Patch applied to wireless-next.git, thanks. 1d60eabb8269 wifi: mwl8k: initialize cmd->addr[] properly -- https://patchwork.kernel.org/project/linux-wireless/patch/b788be9a-15f5-4cca-a3fe-79df4c8ce7b2@moroto.mountain/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches