Received-SPF: pass (google.com: domain of linux-wireless+bounces-7346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 20:31:56 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: quic_bqiang@quicinc.com, linux-wireless@vger.kernel.org,
	ath12k@lists.infradead.org
Subject: Re: [bug report] wifi: ath12k: flush all packets before suspend
Message-ID: <d642bb50-5d79-4968-a001-13bd075c70b0@moroto.mountain>
References: <7a96ca11-80b5-4751-8cfc-fa637f3aa63a@moroto.mountain>
 <1abbdd0c-d4cf-4e24-9b68-d732b07300ff@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1abbdd0c-d4cf-4e24-9b68-d732b07300ff@quicinc.com>

On Wed, May 08, 2024 at 09:51:33AM -0700, Jeff Johnson wrote:
> On 5/8/2024 5:29 AM, Dan Carpenter wrote:
> > Hello Baochen Qiang,
> > 
> > Commit 692921ead832 ("wifi: ath12k: flush all packets before
> > suspend") from Apr 22, 2024 (linux-next), leads to the following
> > Smatch static checker warning:
> > 
> > 	drivers/net/wireless/ath/ath12k/core.c:58 ath12k_core_suspend()
> > 	warn: sleeping in atomic context
> 
> Hi Dan,
> I'm not seeing this as part of my standard make W=1 C=1
> 
> What do I need to do in order to see this?
> build_kernel_data.sh ??
>

Yeah.  This is a smatch warning that requires build_kernel_data.sh
(probably you have to build several times which takes forever).  The
might_sleep() is in synchronize_net().

It's better to do run time testing.  If you run with
CONFIG_DEBUG_ATOMIC_SLEEP=y
then it will trigger a stack trace.

regards,
dan carpenter