Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp947632lqo; Wed, 8 May 2024 23:15:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV6LB1HuutXypHT4KYTmeatZOkHy7PkJ77NwUdTki+d063uw4Wu0hsi2l92nS2IFWKgJkBDJfd3xEHVgviHY9H2GZowbklaPkpu4I9Cyg== X-Google-Smtp-Source: AGHT+IGZhpT60SovrluFjt+iGeIO7Mv6h6vzDzGESBenv+f1Xo2V4RA/ypUOhBS3o5iE+VOK2QdC X-Received: by 2002:a25:b126:0:b0:de5:5a6f:a52a with SMTP id 3f1490d57ef6-debb9d90cb3mr4908751276.26.1715235313848; Wed, 08 May 2024 23:15:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715235313; cv=pass; d=google.com; s=arc-20160816; b=JWedelwh5/Bxy3qF/ueEtUR8t1PCApaM7G7u73Sa8KnWxFhgi6+fDUPXAB14qCMLs6 nvy9qluCBSiX8dgnDFHYA+x7noAmEITFA1vaZLSOK/wK115Jjg8ymlk/hmQnYDsbzqGg eMSZ20pPQh/fMdQoIvbf/0eqDwC7WiBdohFiQJSKa77dmjnPpTqg30ttt9MwRNpcoXuj /cR79Ka9yXTdpOe6HZN26TtT1N3bM05qqwmpP3P8T5W0oy1X7XbyJeYC9/KcWu/lTaQn 4KS4eUf2wtqTIqZQ1fB93+FvIOflLaDNrqn5Tatsn593ewbKcQKoTURBYKPDJhHO1Mzk PsPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:cc:to:from; bh=jQmikC87lnagVGJQMCzOpXt9YE98mCWXp+Nbo2QEv50=; fh=Yil9fXfTUUzGZ+WmNwW74Ny6hwIzbe21qD5AEifVziQ=; b=YM5i64m1BCs58m+8VFyie/SC48wIIe6JLrLgdIgsnm56456r/nK0Cud4wLNSrNuphL XLbhoneUDN0YxVg5pV26uMeSEKzvmznP8IiOQ2QEo4OAC8Jhqi/Uya0jIkFT8SblCR0e xltcTJIqOfpmUTAqFENLvVENdtWW99F1nnVm+ZT1Hf7thGzhrQBqQxpGos34cyW/Ax78 eim01w/ScgVQpGm10R1V8XKF+CkpZLZGpALoHprHpEDne4t1ftYDrxFfB7pvJyIVkYHo WfM5vebST72GjjnAouXIPWFCuuXEZ3LDXghOpRC7AVJFlepE+FJxvkbvBLq7EzxP56+9 gvgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-7372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7372-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-792bf30a93bsi62403185a.242.2024.05.08.23.15.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 23:15:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-7372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7372-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E157F1C20C91 for ; Thu, 9 May 2024 06:15:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E260F26AE0; Thu, 9 May 2024 06:15:09 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72552323D; Thu, 9 May 2024 06:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715235309; cv=none; b=jKusxN1UNOGOP53jYUW42RA9qwOB1eXDWCmp47SIoba0cL5/vFwdY8im5jgzDLI+r8o9kjvmXCjuKdeUpvAZahlmprsGjiGJFw2XOso5vM8GXD1CbVmJHEWBsDJgAZhc4TyrJ+9MTs/XvHydrgG0ydQ8ir944nSobXEyI0rbj9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715235309; c=relaxed/simple; bh=oPlADKq3dZQhdgv+M3VHYgl+ufuBSPhRnb8kHcaUZkk=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=X8HoE59Gq3jU9hdkE9jBhxtuSzmc5Ro/KC8s8dnF3RzuDP2o1J+ztdfOUJg6CGCLBZFBmQ+nPp8EmYDblm0v+2YO8C17aCpN30Dm1Ppy0g6FMIfLJYq1hutiRPCltiDZvN79Q/OWuBtRXyvnSTUG3ELboLnx6prxc1IwmbZNIwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 4496EgGxA1286859, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 4496EgGxA1286859 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 May 2024 14:14:42 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 14:14:42 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 14:14:41 +0800 From: Ping-Ke Shih To: Breno Leitao , Ping-Ke Shih , "Kalle Valo" CC: , "open list:REALTEK WIRELESS DRIVER (rtw89)" , open list Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device In-Reply-To: <20240424182351.3936556-1-leitao@debian.org> References: <20240424182351.3936556-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: Date: Thu, 9 May 2024 14:14:41 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Breno Leitao wrote: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from the private struct by converting it > into a pointer. Then use the leverage the new alloc_netdev_dummy() > helper to allocate and initialize dummy devices. > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > > Signed-off-by: Breno Leitao > Acked-by: Ping-Ke Shih > Tested-by: Ping-Ke Shih 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 4c9aa94a39e6 wifi: rtw89: Un-embed dummy device --- https://github.com/pkshih/rtw.git