Received-SPF: pass (google.com: domain of linux-wireless+bounces-7376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 9 May 2024 00:48:00 -0700
From: Breno Leitao <leitao@debian.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@kernel.org>, "leit@meta.com" <leit@meta.com>,
	"open list:REALTEK WIRELESS DRIVER (rtw89)" <linux-wireless@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device
Message-ID: <Zjx/sKB++v8FJMXx@gmail.com>
References: <20240424182351.3936556-1-leitao@debian.org>
 <f46ae94488d1468e9a9a669320e4cfb9@realtek.com>
 <87ttjqgf2r.fsf@kernel.org>
 <87mspigex0.fsf@kernel.org>
 <acda4194c8d44690b05b83adccb3aa22@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <acda4194c8d44690b05b83adccb3aa22@realtek.com>

On Thu, Apr 25, 2024 at 06:15:21AM +0000, Ping-Ke Shih wrote:
> Kalle Valo <kvalo@kernel.org> wrote:
> > Kalle Valo <kvalo@kernel.org> writes:
> > 
> > > Ping-Ke Shih <pkshih@realtek.com> writes:
> > >
> > >> Breno Leitao <leitao@debian.org> wrote:
> > >>> Embedding net_device into structures prohibits the usage of flexible
> > >>> arrays in the net_device structure. For more details, see the discussion
> > >>> at [1].
> > >>>
> > >>> Un-embed the net_device from the private struct by converting it
> > >>> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> > >>> helper to allocate and initialize dummy devices.
> > >>>
> > >>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> > >>>
> > >>> Signed-off-by: Breno Leitao <leitao@debian.org>
> > >>
> > >> I think this patch should go via net-next tree, because wireless-next tree
> > >> doesn't have patch of dummy devices yet.
> > >>
> > >> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> > >
> > > FWIW I sent the wireless-next pull request yesterday and once it pulled
> > > we will fast forward wireless-next to latest net-next.
> > 
> > Oh, I just realised that this is not CCed to netdev so their patchwork
> > won't even see the patch. Ping, I recommend that you wait for the
> > dependency commits to trickle down to your tree and then apply the
> > patch. That's the simplest approach and no need to resend anything.
> 
> Okay. If we don't hurry to get this patch merged, I will apply this patch
> to my tree.

There is no hurry to get this patch merged.

Out of curiosity, why don't you rebase your tree to net-next/linux-next
frequently?