Received-SPF: pass (google.com: domain of linux-wireless+bounces-7446-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: "Luca Weiss" <luca.weiss@fairphone.com>
Cc: "Carl Huang" <quic_cjhuang@quicinc.com>,  <ath11k@lists.infradead.org>,
  <linux-wireless@vger.kernel.org>,
    regressions@lists.linux.dev
Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces
References: <20230714023801.2621802-1-quic_cjhuang@quicinc.com>
	<20230714023801.2621802-2-quic_cjhuang@quicinc.com>
	<D15TIIDIIESY.D1EKKJLZINMA@fairphone.com>
Date: Fri, 10 May 2024 13:18:55 +0300
In-Reply-To: <D15TIIDIIESY.D1EKKJLZINMA@fairphone.com> (Luca Weiss's message
	of "Fri, 10 May 2024 10:22:50 +0200")
Message-ID: <87jzk2km0g.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

"Luca Weiss" <luca.weiss@fairphone.com> writes:

> On Fri Jul 14, 2023 at 4:38 AM CEST, Carl Huang wrote:
>> Add hardware parameter support_dual_stations to indicate
>> whether 2 station interfaces are supported. For chips which
>> support this feature, limit total number of AP interface and
>> mesh point to 1. The max interfaces are 3 for such chips.
>>
>> The chips affected are:
>>  QCA6390 hw2.0
>>  WCN6855 hw2.0
>>  WCN6855 hw2.1
>> Other chips are not affected.
>>
>> For affected chips, remove radar_detect_widths because now
>> num_different_channels is set to 2. radar_detect_widths can
>> be set only when num_different_channels is 1. See mac80211
>> function wiphy_verify_combinations for details.
>>
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Hi Carl,
>
> Unfortunately this commit breaks wifi on a QCM6490 smartphone
> (qcm6490-fairphone-fp5) and makes the board crash.
>
> Reverting this commit (plus for conflict resolution 5dc9d1a55e95 ("wifi:
> ath11k: add support for QCA2066") and 24395ec11707 ("wifi: ath11k:
> provide address list if chip supports 2 stations")) makes wifi work
> again.

Thanks for the report. So the broken commit is:

f019f4dff2e4 wifi: ath11k: support 2 station interfaces

This went into v6.9-rc1 so I'm guessing that WCN6750 support will be
fully broken in v6.9? Not good. And most likely Linus will release v6.9
on Sunday so it's too late to get a fix included in the final release.

Carl, can you fix this ASAP? Or should we just revert the broken
commits?

Adding this to our regression tracking:

#regzbot introduced: f019f4dff2e4 ^
#regzbot title: ath11k: WCN6750 firmware crashes during initialisation

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches