Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp440441lqo; Fri, 10 May 2024 04:56:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVM+jqzocXKtjAhSWBFuzr2TMMn25CaXVD7IAWJgdKqwVLhgrU28rJk4+enycvknY49qHqfMXMobuvBOMEhyxM1+nhjfxq5RcDGpdV2kQ== X-Google-Smtp-Source: AGHT+IHdKGx5Eg7f1+F7lHMnalHd/p9FIg3miLBk7u4l7lXREdXOh/udYk/VUSDsd3PZHoWsdoEV X-Received: by 2002:a17:906:4086:b0:a59:c52b:9936 with SMTP id a640c23a62f3a-a5a2d5c85f1mr154821366b.26.1715342205055; Fri, 10 May 2024 04:56:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715342205; cv=pass; d=google.com; s=arc-20160816; b=Du5iD52ni9JvSQtW0q9BFBLnxjX/Pnx9Np/w8UOW7Xtyz9kYSzPJkPa1ySqNfr1XF3 YJsp3Eec0AdAfncYnuUx9lQg8/zXChogPMpMrQst8RJfDG+uA6/yE1HcAroBeobSIJCs 82g6WK66i+Uh4OdQg+KR/rbyiSSu67g0jNZfFvTlaw3w6XbAxTHFQm+Nv+dDoxB2s0Mn WO6y5IBh0b+Luxl8x8zsYGYN1reDwqept0QjUNA1syFKnAZ/D/NDvy26e/InCAk8n+tQ ppcTC0cptaROrJbJ9KoG9/peafvqqf9mlPUMn3nM1csafUu+fNJydLYOngTwxEU5f/DR FhVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pCEMuv8BTNqITNiWoBmlEd6p9ZCB/YHE6vsTffCJw0E=; fh=zWBjB8QjF/YU2GVjAZmqqmTzsQv0JpddqwWfHL3BHo8=; b=xHZ/68BQCEIvCN77YOV4P9eGatLhXF9uAHgG6VfzKkKH/fBYADP7bIjyVOcD0YugmQ a8QBjeOQR91TdeOXeAIJw8unWjOL9jGayPLxEouRVqyajYOuzD/xK/L2wVp8Qn9V2GMp guVDf3yRb2w7Uy6R94LorfL+sKb5AXZPK8wWeyEd+A9R6JMU1EhMePzLluN/tjtgHK3N one5EFJ4O/j+7hShnIQ7hm10Ykfxuwl3HJZWgwHZk9rna/fxqfx+aOokA4zwv/D0jYyQ Ht3tYonND/L8wmmyZzP3soDxer7MI6a3Sxilanl5rywoLTGq2AgyQy2fN2LA+m8NWO6l 9EVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hlp55sxB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7451-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7451-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a1794606fsi221201966b.190.2024.05.10.04.56.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 04:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7451-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hlp55sxB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7451-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7451-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 542DD1F210A2 for ; Fri, 10 May 2024 11:56:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D85F216E890; Fri, 10 May 2024 11:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hlp55sxB" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA69E3AC16; Fri, 10 May 2024 11:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715342199; cv=none; b=qqX3oXe9Vja/5x+c8xQQgXuaV/LhWeSzfaOlK39ntLJDEKtjr9z4JH/k3g/oyXm1l+Kffq9PMxEd7PQijznhvY1RNV7RfLNdjdNElG15qy94ZG8xggbPYKDH/EvfLhhvKrU1t0YlMfZwItDxDW+GqCJSICf4QrWXshDkuljuq3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715342199; c=relaxed/simple; bh=Sg1yNj7sz3TgmJXgjsW9mK/1ks9fy6gk2t2h724Zu/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HC8kZZ7AaAACfmYO/LCyGpOuZtO3XRPIbXCw40F4pbGculmOuE4AHd8Q/UKXXCnbKN5xGAzS1bOZlK6tbMNufPcYC7qElEtWPqxBXvYCcwbW3nchvFidn7bY5POOz4coRmaYs8M76DgmpwMdsNlc13LQlXUNr1MNlA1Q0Un7X8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hlp55sxB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2BE1C113CC; Fri, 10 May 2024 11:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715342199; bh=Sg1yNj7sz3TgmJXgjsW9mK/1ks9fy6gk2t2h724Zu/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlp55sxB0TjgbLIK7NtwytShjU39kvivxmsofCkbGqorK7SU+HQlQoIueRiZ22J0W Lf+8QPYqjysh/K37yBrG2GvvzkfZkCdSz+gqsolYELyNW5y5BTAEAi8YakZI7KD0bG 0gcC2eL/CbrNzZy9KFQDjARsCrkrUML33SAQkha4CLsMBznCP4nVZBX/q46hCwQGhB a7hbdHT5SlulYji9U4WgPGnqMhgTeJgzPQh3ek8/rz52pQOdvlVBDV5UYIaW+/bFOq 35UM359xepPSAO7FHUT+eb5qzRpBbvWlUZn9vpu/nrrrjaKv7sJyBvWCMawz6sd5QI 0Yjoa3jz1X/rA== Date: Fri, 10 May 2024 12:56:33 +0100 From: Simon Horman To: Breno Leitao Cc: Kalle Valo , Jeff Johnson , "David S. Miller" , netdev@vger.kernel.org, "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH11K WIRELESS DRIVER" , open list Subject: Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config Message-ID: <20240510115633.GS2347895@kernel.org> References: <20240508185902.70975-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240508185902.70975-1-leitao@debian.org> On Wed, May 08, 2024 at 11:59:01AM -0700, Breno Leitao wrote: > If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(), > the previous allocated devices might leak due to returning without > deallocating the devices. > > Instead of returning on the error path, deallocate all the previously > allocated net_devices and then return. > > Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically") > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman