Received-SPF: pass (google.com: domain of linux-wireless+bounces-7452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <93c15c59-f24c-4472-ae7e-969fd1e3bfec@quicinc.com>
Date: Fri, 10 May 2024 20:03:28 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <quic_cjhuang@quicinc.com>, <ath11k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>, <regressions@lists.linux.dev>
Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces
To: Kalle Valo <kvalo@kernel.org>, Luca Weiss <luca.weiss@fairphone.com>
References: <20230714023801.2621802-1-quic_cjhuang@quicinc.com>
 <20230714023801.2621802-2-quic_cjhuang@quicinc.com>
 <D15TIIDIIESY.D1EKKJLZINMA@fairphone.com> <87jzk2km0g.fsf@kernel.org>
Content-Language: en-US
From: Carl Huang <quic_cjhuang@quicinc.com>
In-Reply-To: <87jzk2km0g.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/5/10 18:18, Kalle Valo wrote:
> "Luca Weiss" <luca.weiss@fairphone.com> writes:
> 
>> On Fri Jul 14, 2023 at 4:38 AM CEST, Carl Huang wrote:
>>> Add hardware parameter support_dual_stations to indicate
>>> whether 2 station interfaces are supported. For chips which
>>> support this feature, limit total number of AP interface and
>>> mesh point to 1. The max interfaces are 3 for such chips.
>>>
>>> The chips affected are:
>>>   QCA6390 hw2.0
>>>   WCN6855 hw2.0
>>>   WCN6855 hw2.1
>>> Other chips are not affected.
>>>
>>> For affected chips, remove radar_detect_widths because now
>>> num_different_channels is set to 2. radar_detect_widths can
>>> be set only when num_different_channels is 1. See mac80211
>>> function wiphy_verify_combinations for details.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>
>> Hi Carl,
>>
>> Unfortunately this commit breaks wifi on a QCM6490 smartphone
>> (qcm6490-fairphone-fp5) and makes the board crash.
>>
>> Reverting this commit (plus for conflict resolution 5dc9d1a55e95 ("wifi:
>> ath11k: add support for QCA2066") and 24395ec11707 ("wifi: ath11k:
>> provide address list if chip supports 2 stations")) makes wifi work
>> again.
> 
> Thanks for the report. So the broken commit is:
> 
> f019f4dff2e4 wifi: ath11k: support 2 station interfaces
> 
> This went into v6.9-rc1 so I'm guessing that WCN6750 support will be
> fully broken in v6.9? Not good. And most likely Linus will release v6.9
> on Sunday so it's too late to get a fix included in the final release.
> 
> Carl, can you fix this ASAP? Or should we just revert the broken
> commits?
> 
> Adding this to our regression tracking:
> 
> #regzbot introduced: f019f4dff2e4 ^
> #regzbot title: ath11k: WCN6750 firmware crashes during initialisation
> 
Kalle, looks we're not able to fix it before Sunday as I don't have 
WCN6750 setup to verify the fix. The fix could be to define a dedicated 
function ath11k_init_wmi_config_wcn6750() for WCN6750. I'll send the 
patch out so others like Luca can have a try.