Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp554870lqo; Fri, 10 May 2024 07:54:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUWO0Ht0qMXOHBa0Q0MxwDsIrz69AhMmvG1EJJWARdWg4T4UEUX7wfPoykBoqt3+q10mEL565zebs2FSh5aaUNdYfppLKZsHEHL1yyEHQ== X-Google-Smtp-Source: AGHT+IETLh+wWVFgnl8YN6bZ8KwbOf48Mt8GbgJ9jhn2lgRcifvr+6IYPQdi1WfG4VMfR2pvJ2fp X-Received: by 2002:a05:6830:411d:b0:6f0:4f53:5158 with SMTP id 46e09a7af769-6f0e92a7f02mr3682476a34.24.1715352890319; Fri, 10 May 2024 07:54:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715352890; cv=pass; d=google.com; s=arc-20160816; b=E/+fjMcsRNGOiB3cZYCA5wtPsXTe+ozAKmpHKEdKnnOTBqoi3E6xFF+ICAvVErmda0 Y+I4jDCwZ98Om7YZjsIgnfvF/4MobbQKlR5aWnObfM3jJK/7ebJbxmW6Dzz0c8orre86 NvBC7Ht+hRyQgX7GZeuwKRNR/Z1F60lgORtt8hCLDrrxke6vvKc5iNSL3OLMs+fSlYXC 2zrgSHRbevFJk+EAHKn9ZwI4WyikXxQFyKvDWtoVMh7sqqqUXHDEDxNG1IIxIvUuRe/0 MWHThR0GnaHOz5k1Hf8ZptL0t3ycQVG0DoVJ4oKvv94BrC1ClfHdZ34mVCovMe63yU1X 8gJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=3ug0KQ5oaG2qwKoniCU5R5E+xTRuNofmc/DcAotezNQ=; fh=DWuDVCHveaNFKdKc5WZeQpY9RB452EAwlcQHEdezk5I=; b=nV4bR2pk19Y3yTcKezRhCXz5pbSzkzKmURE12OkSGOrhYrQvOKABOpdDEJaCiOLNh3 waVdQnRvpGhW7qQsMPcbHvMHKs7/NHM/cDbjoKSkhtotlhOLcqqD4Mz/5mCGUpOSqwoC QpKtFTZqal9sjo63EU+sxCyQVbmcZoTPlkeQexcjcK4Zhe6hpjz94aHr+eJ2o1buBF+h 6O7F356odVa1NzM+lSTvMGy5pXTHR9+AWUi/TmOBfi9erxoqS37uHhhYy04aKONiJOd9 K9Ab+D0l/v9xW2ZL/pVPIvsDFN49amnJ0bzrAtDlknysVtsBXJait+KQSzowtm48KGhG f+uw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Xfq057j7; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7479-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7479-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-792bf278787si362899285a.121.2024.05.10.07.54.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 07:54:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7479-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Xfq057j7; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-7479-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7479-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5A7AF1C22318 for ; Fri, 10 May 2024 14:54:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B81C17106E; Fri, 10 May 2024 14:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Xfq057j7" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7606D17106B; Fri, 10 May 2024 14:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715352886; cv=none; b=eHKaSBDX7hniZT0Km6Brr2p7/bofP2fChBPIFEMlUX+OK3VY6IsJ+IlT54if87tOmx5Xp5DgSmanpxW9q1DFigD79A1uKxr0BzMT5ArSbLoydlY6Y0KMFNG4gqm1aX0kxt5SWNyewGFJC3ExczyRgnT75AK9Fe7ek4rEgeGG0lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715352886; c=relaxed/simple; bh=QiKKY9PSdLFE28M/Q7BzO99YFAu8REW5hZxTDsCrPWA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=t+qKyWOo/dDr6en7iDDdVe4fO69qfp7VMHKcXPKZLL15oWZb0Mv0YUw2x7byI/1fqmXcy0bHcoX7mtwT1qB0HpN1unwfVsxvUhX7SeJzVz/uAM3uT5LESJD3WJiBYde7YDide/rHc/kT+tHZJSYUhnB5qjMbxqldwI1gd4ggcUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Xfq057j7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44ADBST1019386; Fri, 10 May 2024 14:54:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=3ug0KQ5oaG2qwKoniCU5R5E+xTRuNofmc/DcAotezNQ=; b=Xf q057j7MdmmGyrv/9L9F9UdHeRtQKFgVWNKxEBao/eurTy/ww7vMei8NPrwboMkoS slTbkntwIcOcNO5niOS5Z/H61YUbtGx27oczCtWDfkPXdPusIU8Dh8y6tdx1EHj3 uLz7ILD9il3JM0Lne9QL+klznLt2GbSqT2y7kxGx1Dm+PLPET/nzmzuvtlJC8CjO ubJjRRR7DswpI5xQFYD662eLgE0g62YrHMuMa1FJK7RisxDfbMkSWxbNmbJlHX5a ncrx26mHZ5h3khEoJYaZ+Pzm7N0/wHdYTOrde06KQC9AOfPfiZ9dhcQ84SKwaMwb PGOJTy+NNZ95XxKWIZWw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3y16w1hs4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 May 2024 14:54:25 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 44AEsOAQ005361 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 May 2024 14:54:24 GMT Received: from [10.110.100.57] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 10 May 2024 07:54:23 -0700 Message-ID: Date: Fri, 10 May 2024 07:54:23 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14] ath10k: add LED and GPIO controlling support for various chipsets Content-Language: en-US To: Christian Marangi CC: Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , , , Sebastian Gottschall , Steve deRosier , Stefan Lippers-Hollmann References: <20230611080505.17393-1-ansuelsmth@gmail.com> <878rcjbaqs.fsf@kernel.org> <648cdebb.5d0a0220.be7f8.a096@mx.google.com> <648ded2a.df0a0220.b78de.4603@mx.google.com> <87v83nlhb3.fsf@kernel.org> <7585e7c3-8be6-45a6-96b3-ecb4b98b12d8@quicinc.com> <663e2bd9.5d0a0220.d970d.cbf8@mx.google.com> From: Jeff Johnson In-Reply-To: <663e2bd9.5d0a0220.d970d.cbf8@mx.google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: qVnK9dRRwg18lc-CZ3pWZOj82YORCYY7 X-Proofpoint-GUID: qVnK9dRRwg18lc-CZ3pWZOj82YORCYY7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-10_10,2024-05-10_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 mlxlogscore=827 mlxscore=0 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405010000 definitions=main-2405100107 On 5/10/2024 7:14 AM, Christian Marangi wrote: > On Thu, May 09, 2024 at 09:48:08AM -0700, Jeff Johnson wrote: >> On 5/9/2024 9:37 AM, Jeff Johnson wrote: >>> On 5/8/2024 9:50 PM, Kalle Valo wrote: >>>> Sorry for the delay but finally I looked at this again. I decided to >>>> just remove the fixme and otherwise it looks good for me. Please check >>>> my changes: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=688130a66ed49f20ca0ce02c3987f6a474f7c93a >>>> >>> >>> I have a question about the copyrights in the two new files: >>> + * Copyright (c) 2018-2023, The Linux Foundation. All rights reserved. >>> >>> My understanding is that Qualcomm's affiliation with Linux Foundation via Code >>> Aurora ended in December 2021, and hence any contributions in 2022-2023 should >>> be the copyright of Qualcomm Innovation Center, Inc. >>> >>> >> >> ok it seems like Kalle's v13 had: >> + * Copyright (c) 2018, The Linux Foundation. All rights reserved. >> >> and Ansuel's v14 has: >> + * Copyright (c) 2018-2023, The Linux Foundation. All rights reserved. >> >> So Ansuel, is your work on behalf of The Linux Foundation? >> > > When I resubmitted this at times, I just updated the copyright to the > current year so I guess it was wrong doing that? > > As you can see from the copyright header this patch went all around and > I think at the end (around 2018) the Linux copyright was added as it was > submitted upstream. (can't remember if maintainers were asking that) > > So me watching the old year and resubmitting it, just updated the date. > > Soo I think we should revert to 2018? > Yes, in this case changing the Linux Foundation copyright back to 2018 is correct. /jeff