Received-SPF: pass (google.com: domain of linux-wireless+bounces-7498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <88af0514-d618-4a47-94d4-163b0e58b9f2@quicinc.com>
Date: Sat, 11 May 2024 10:50:43 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <quic_cjhuang@quicinc.com>, <ath11k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>, <regressions@lists.linux.dev>
Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces
To: Luca Weiss <luca.weiss@fairphone.com>, Kalle Valo <kvalo@kernel.org>
References: <20230714023801.2621802-1-quic_cjhuang@quicinc.com>
 <20230714023801.2621802-2-quic_cjhuang@quicinc.com>
 <D15TIIDIIESY.D1EKKJLZINMA@fairphone.com> <87jzk2km0g.fsf@kernel.org>
 <93c15c59-f24c-4472-ae7e-969fd1e3bfec@quicinc.com>
 <4d60ccf3-455d-4189-9100-d35488b00236@quicinc.com>
 <D15ZZ5V3YU6Z.10FO9XK11WXFB@fairphone.com>
Content-Language: en-US
From: Carl Huang <quic_cjhuang@quicinc.com>
In-Reply-To: <D15ZZ5V3YU6Z.10FO9XK11WXFB@fairphone.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/5/10 21:26, Luca Weiss wrote:
> On Fri May 10, 2024 at 3:04 PM CEST, Carl Huang wrote:
> 
> <snip>
> 
>>> Kalle, looks we're not able to fix it before Sunday as I don't have
>>> WCN6750 setup to verify the fix. The fix could be to define a dedicated
>>> function ath11k_init_wmi_config_wcn6750() for WCN6750. I'll send the
>>> patch out so others like Luca can have a try.
>>>
>> Sorry, I have problem to run "git send-email" as it prompts "5.7.60
>> SMTP; Client does not have permissions to send as this sender".
>>
>> The patch looks like:
>>
>>   From 19bb7f1377a5e3c5d42ab2bedbaf9e976c1068b4 Mon Sep 17 00:00:00 2001
>> From: Carl Huang <quic_cjhuang@quicinc.com>
>> Date: Fri, 10 May 2024 19:40:37 +0800
>> Subject: [PATCH] wifi:ath11k: fix WCN6750 firmware crash
>>
>> WCN6750 firmware crashed because of vdev_number changed to 3 from 4
>> in commit f019f4dff2e4("wifi: ath11k: support 2 station interfaces").
>>
>> Fix it by defining a separate function ath11k_init_wmi_config_wcn6750()
>> for WCN6750 to initialize its' specific parameters.
>>
>> Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
>> Tested-on: WCN6855 hw2.0 PCI
>> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>
>> Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
> 
> This seems to work fine also.
> 
Thank you Luca for the test.