Received-SPF: pass (google.com: domain of linux-wireless+bounces-7550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b1cf7a1c-7f96-4c00-a9b5-da5f2648fe7c@quicinc.com>
Date: Sun, 12 May 2024 17:58:24 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: mac80211: move radar detect work to sdata
To: Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
CC: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
References: <20240506211311.43bd82c6da04.Ib39bec3aa198d137385f081e7e1910dcbde3aa1b@changeid>
 <4dd39edb-cd23-482a-8c94-b09142d92198@quicinc.com>
 <88b36efce036ad4f0316ffb434a5352bbe4f1599.camel@sipsolutions.net>
Content-Language: en-US
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <88b36efce036ad4f0316ffb434a5352bbe4f1599.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 5/10/24 19:57, Johannes Berg wrote:
> On Thu, 2024-05-09 at 09:52 +0530, Aditya Kumar Singh wrote:
>> On 5/7/24 00:43, Johannes Berg wrote:
>>> At some point we thought perhaps this could be per link, but
>>> really that didn't happen, and it's confusing. Radar detection
>>> still uses the deflink to allocate the channel, but the work
>>> need not be there. Move it back.
>>
>> I'm currently working on MLO DFS support. It is better if the work can
>> be left in per link structure. With proper support, instead of deflink
>> it will use appropriate link.
> 
> A number of patches I have actually depend on this (though only by
> patch, not semantically), so it might be better to leave it and just
> move it back.

Oh I see :)

> 
> In any case, your work will likely have (simple) conflicts in some
> places with the other patches I posted.

Yes correct. Those are minor as far as I saw them and those seems fine 
as well. But this one, felt like I will be reverting it soon so if 
possible let's not merge it unless it is affecting the code base.

> 
> But we have a couple of weeks to decide, I guess, given the release is
> around the corner.
> 
Sure. I'm doing testing as of now with my changes so it will take some 
time to appear here. If your changes gets merged by then, I will rebase it.