Received-SPF: pass (google.com: domain of linux-wireless+bounces-7551-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d104ea7f-5a88-4081-a651-c25a88a2acf7@gmail.com>
Date: Sun, 12 May 2024 17:34:58 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH v5 03/11] wifi: rtlwifi: Add rtl8192du/hw.{c,h}
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
 Stefan Lippers-Hollmann <s.l-h@gmx.de>,
 Christian Hewitt <chewitt@libreelec.tv>
References: <254558da-ea8b-40ea-bd5a-83d13796744f@gmail.com>
 <d5d52f8d-585d-43a6-a5e6-076f24ba8410@gmail.com>
 <31f28650173d40cf85fb57f87949eef7@realtek.com>
Content-Language: en-US
In-Reply-To: <31f28650173d40cf85fb57f87949eef7@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/05/2024 06:04, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> 
>> +
>> +int rtl92du_hw_init(struct ieee80211_hw *hw)
>> +{
>> +       struct rtl_usb_priv *usb_priv = rtl_usbpriv(hw);
>> +       struct rtl_usb *rtlusb = rtl_usbdev(usb_priv);
>> +       struct rtl_priv *rtlpriv = rtl_priv(hw);
>> +       struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv);
>> +       struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
>> +       struct rtl_mac *mac = rtl_mac(rtlpriv);
>> +       struct rtl_phy *rtlphy = &rtlpriv->phy;
>> +       u8 val8, txpktbuf_bndy;
>> +       unsigned long flags;
>> +       int err, i;
>> +       u32 val32;
>> +       u16 val16;
>> +
>> +       /* As this function can take a very long time
>> +        * and can be called with irqs disabled, reenable the irqs
>> +        * to let the other devices continue being serviced.
>> +        *
>> +        * It is safe doing so since our own interrupts will only be enabled
>> +        * in a subsequent step.
>> +        */
>> +       local_save_flags(flags);
>> +       local_irq_enable();
> 
> I think you just copy and paste this chunk. I wonder if USB has the same behavior?
> Driver force to enable IRQ is weird to me. Please check I this is really called
> with irq disabled? If not, we can remove them.
> 

Yes, I copied that. Removing it from rtl8192du makes no
difference for me. I'm not sure how to check if the function
is called with irq disabled. Is it raw_irqs_disabled() ?
It returns 0 for me.

> [...]
> 
>> +       local_irq_disable();
>> +       local_irq_restore(flags);
>> +
>> +       return err;
>> +}
>> +
> 
>