Received-SPF: pass (google.com: domain of linux-wireless+bounces-7576-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: <michael.nemanov@ti.com>
Cc: <linux-wireless@vger.kernel.org>,  <sabeeh-khan@ti.com>
Subject: Re: [RFC PATCH 00/17] wifi: cc33xx: Add driver for new TI CC33xx
 wireless device family
References: <20240512183247.2190242-1-michael.nemanov@ti.com>
Date: Mon, 13 May 2024 09:42:51 +0300
In-Reply-To: <20240512183247.2190242-1-michael.nemanov@ti.com> (michael
	nemanov's message of "Sun, 12 May 2024 21:32:30 +0300")
Message-ID: <87cypqjjpw.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

<michael.nemanov@ti.com> writes:

> From: Michael Nemanov <michael.nemanov@ti.com>
>
> This series adds support for CC33xx which is a new family of WLAN IEEE802.11 a/b/g/n/ax
> and BLE 5.4 transceivers by Texas Instruments. These devices are 20MHz single spatial stream
> enabling STA (IEEE802.11ax) and AP (IEEE802.11n only) roles as well as both roles simultaneously.
> Communication to the CC33xx is done via 4-bit SDIO with two extra
> GPIOs: Enable and Interrupt.

I didn't review this yet but decided to do some build testing and it
doesn't even build:

drivers/net/wireless/ti/cc33xx/debugfs.c: In function 'cc33xx_debugfs_add_files_helper':
drivers/net/wireless/ti/cc33xx/debugfs.h:37:37: error: 'cc' undeclared (first use in this function)

I also see some warnings from GCC. I pushed the patches to a pending
branch so most likely you get reports from kbuild bot:

https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/log/?h=pending

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches