Received-SPF: pass (google.com: domain of linux-wireless+bounces-7600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3fb87569-61af-4779-a468-5e91d50482b3@denx.de>
Date: Mon, 13 May 2024 16:44:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iwlwifi: mvm: Ignore NVM write status 0x1000
To: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Abhishek Naik <abhishek.naik@intel.com>,
 "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
 Gregory Greenman <gregory.greenman@intel.com>,
 "Berg, Johannes" <johannes.berg@intel.com>, Kalle Valo <kvalo@kernel.org>
References: <20240512184932.25831-1-marex@denx.de>
 <MW5PR11MB5810BC2C41C580237BAD3958A3E22@MW5PR11MB5810.namprd11.prod.outlook.com>
Content-Language: en-US
From: Marek Vasut <marex@denx.de>
In-Reply-To: <MW5PR11MB5810BC2C41C580237BAD3958A3E22@MW5PR11MB5810.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/13/24 9:26 AM, Korenblit, Miriam Rachel wrote:
> 
>> -----Original Message-----
>> From: Marek Vasut <marex@denx.de>
>> Sent: Sunday, 12 May 2024 21:49
>> To: linux-wireless@vger.kernel.org
>> Cc: Marek Vasut <marex@denx.de>; Abhishek Naik <abhishek.naik@intel.com>;
>> Grumbach, Emmanuel <emmanuel.grumbach@intel.com>; Gregory Greenman
>> <gregory.greenman@intel.com>; Berg, Johannes <johannes.berg@intel.com>;
>> Kalle Valo <kvalo@kernel.org>; Korenblit, Miriam Rachel
>> <miriam.rachel.korenblit@intel.com>
>> Subject: [PATCH] iwlwifi: mvm: Ignore NVM write status 0x1000
>>
>> When loading custom NVM file on Wireless-AC 9260 160MHz, REV=0x324
>> 8086:2526 (rev 29) Subsystem: 8086:001c firmware version 46.6b541b68.0 9260-
>> th-b0-jf-b0-46.ucode , the NVM_WRITE_OPCODE return status is 0x1000 for all
>> sections. What does this mean is unknown, however clearing the top 4 bits
>> permits the NVM to be written and the card operates as it should.
>>
>> Hexdump of the iNVM file is below, the iNVM file overrides antenna settings to
>> only use AUX antenna and disables MIMO .
> 
> The custom NVM is meant for internal use only.

But why does NVM loading not work without this patch ?

> To override antenna settings please use the nl80211 command: NL80211_CMD_SET_WIPHY
> You can use the 'iw set antenna' command.

I need to use only the AUX antenna and disable MIMO entirely, the 'iw 
set antenna' didn't work, the custom NVM fragment does work.

But I do need this extra patch to load the NVM fragment.

Is the patch correct ? Why is the 0x1000 returned and why does it have 
to be masked out ?