Received-SPF: pass (google.com: domain of linux-wireless+bounces-7620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com>
Date: Mon, 13 May 2024 16:31:28 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
Content-Language: en-US
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240511013644.3103905-1-quic_periyasa@quicinc.com>
 <20240511013644.3103905-3-quic_periyasa@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240511013644.3103905-3-quic_periyasa@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
> The current value of the MAX_RADIOS define is 3. However, this value is
> incorrect as the maximum number of radios supported by all devices does
> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.

Use imperative tense: Therefore, modify ...

What is the observed problem, if any, with the current code?

> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
> index 496866673aea..27bec3800bff 100644
> --- a/drivers/net/wireless/ath/ath12k/wmi.h
> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
>  	__le32 buf_len;
>  } __packed;
>  
> -#define MAX_RADIOS 3
> +#define MAX_RADIOS 2
>  
>  #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
>  #define WMI_SEND_TIMEOUT_HZ (3 * HZ)