Received-SPF: pass (google.com: domain of linux-wireless+bounces-7622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <23354bb4-4d12-da14-1764-ea71ab05ff45@quicinc.com>
Date: Tue, 14 May 2024 06:37:29 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240511013644.3103905-1-quic_periyasa@quicinc.com>
 <20240511013644.3103905-3-quic_periyasa@quicinc.com>
 <7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com>
From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
In-Reply-To: <7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 5/14/2024 5:01 AM, Jeff Johnson wrote:
> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>> The current value of the MAX_RADIOS define is 3. However, this value is
>> incorrect as the maximum number of radios supported by all devices does
>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
> 
> Use imperative tense: Therefore, modify ...
> 

Sure, will modify in the next version.

> What is the observed problem, if any, with the current code?
> 

No problem observed but it leads to unnecessary space allocated for the 
hw links in the group and also it gives incorrect perspective to the 
code reader that ath12k support max three radio platform.

>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>> ---
>>   drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
>> index 496866673aea..27bec3800bff 100644
>> --- a/drivers/net/wireless/ath/ath12k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
>> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
>>   	__le32 buf_len;
>>   } __packed;
>>   
>> -#define MAX_RADIOS 3
>> +#define MAX_RADIOS 2
>>   
>>   #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
>>   #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
> 

-- 
Karthikeyan Periyasamy
--
கார்த்திகேயன் பெரியசாமி