Received-SPF: pass (google.com: domain of linux-wireless+bounces-7627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,  <ath12k@lists.infradead.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
References: <20240511013644.3103905-1-quic_periyasa@quicinc.com>
	<20240511013644.3103905-3-quic_periyasa@quicinc.com>
	<7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com>
	<23354bb4-4d12-da14-1764-ea71ab05ff45@quicinc.com>
Date: Tue, 14 May 2024 08:25:11 +0300
In-Reply-To: <23354bb4-4d12-da14-1764-ea71ab05ff45@quicinc.com> (Karthikeyan
	Periyasamy's message of "Tue, 14 May 2024 06:37:29 +0530")
Message-ID: <87cyppdky0.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:

> On 5/14/2024 5:01 AM, Jeff Johnson wrote:
>> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>>> The current value of the MAX_RADIOS define is 3. However, this value is
>>> incorrect as the maximum number of radios supported by all devices does
>>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
>> Use imperative tense: Therefore, modify ...
>> 
>
> Sure, will modify in the next version.
>
>> What is the observed problem, if any, with the current code?
>> 
>
> No problem observed but it leads to unnecessary space allocated for
> the hw links in the group and also it gives incorrect perspective to
> the code reader that ath12k support max three radio platform.

Information like this is always good to include in the commit message.
There's less guessing that way.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches