Received-SPF: pass (google.com: domain of linux-wireless+bounces-7633-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 14 May 2024 10:54:26 +0200
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alexis =?iso-8859-1?Q?Lothor=E9?= <alexis.lothore@bootlin.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [bug report] wifi: wilc1000: convert list management to RCU
Message-ID: <8ee9481f-7677-4a0e-be11-0c81d4bbef9f@suswa.mountain>
References: <3b46ec7c-baee-49fd-b760-3bc12fb12eaf@moroto.mountain>
 <1a982ba8-c5f3-415a-bb39-fae9973b100e@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1a982ba8-c5f3-415a-bb39-fae9973b100e@bootlin.com>

On Mon, May 13, 2024 at 04:16:05PM +0200, Alexis Lothor? wrote:
> Hello Dan,
> sorry for the late reply
> 
> On 5/9/24 15:24, Dan Carpenter wrote:
> > Hello Alexis Lothor?,
> > 
> > Commit f236464f1db7 ("wifi: wilc1000: convert list management to
> > RCU") from Apr 10, 2024 (linux-next), leads to the following Smatch
> > static checker warning:
> > 
> > 	drivers/net/wireless/microchip/wilc1000/mon.c:236 wilc_wfi_init_mon_interface()
> > 	warn: sleeping in atomic context
> 
> I am struggling to reproduce the warning in smatch. I executed those basic steps:
> - clone and build latest smatch
> - checkout linux-next master branch
> - export ARCH and CROSS_COMPILE
> - load a defconfig enabling all features in wilc driver
> - run ~/src/smatch/smatch_scripts/build_kernel_data.sh
> - then run ~/src/smatch/smatch_scripts/test_kernel.sh
> Yet I do no see any mention to wilc in the resulting smatch_warns.txt file. The
> outcome is the same if I run smatch only on the wilc driver:
> - ~/src/smatch/smatch_scripts/kchecker drivers/net/wireless/microchip/
> 
> Am I missing something obvious ?

Yeah.  I'm sorry, I need to write a blog entry about this.  These checks
rely on the cross function database, and you need to rebuild it a bunch
of times.  It's a simple process but very time consuming.

Instead of that, it's better to do run time testing using
CONFIG_DEBUG_ATOMIC_SLEEP=y

regards,
dan carpenter