Received-SPF: pass (google.com: domain of linux-wireless+bounces-7646-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <df076b8c-dcb7-47b4-bf2b-b56def3464d1@quicinc.com>
Date: Tue, 14 May 2024 07:14:59 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] wifi: ath12k: use correct MAX_RADIOS
Content-Language: en-US
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240514063412.3483723-1-quic_periyasa@quicinc.com>
 <20240514063412.3483723-3-quic_periyasa@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240514063412.3483723-3-quic_periyasa@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 5/13/2024 11:34 PM, Karthikeyan Periyasamy wrote:
> The current value of the MAX_RADIOS definition is 3. This is incorrect
> because no device supports more than 2 radios.
> 
> An incorrect MAX_RADIOS value can lead to:
>  - unnecessary memory allocation for pdev related entities.
>  - invalid pdev id validation.
>  - Misconceptions for code readers.
> 
> Therefore, modify the MAX_RADIOS definition as 2.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>