Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp3264070lqo; Wed, 15 May 2024 04:57:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXbSYrMvwqESefFtZCkZezsLQdu24dtib90GThSNiuMCSfPXVSTM5CV/WN9BZWS+K5iwYfmqIVVnJwRjiordqwm/09yx3FHa1CMvXqeZQ== X-Google-Smtp-Source: AGHT+IEDPqLiE/wMuwJIh1DMcRa7UVhV8X2y2EMU8Vr9f87xEZIL6ufNQhJW7XqQtlXFn0Bd+VjX X-Received: by 2002:a05:6122:4594:b0:4d8:7a5e:392f with SMTP id 71dfb90a1353d-4df8833debamr13780633e0c.12.1715774271908; Wed, 15 May 2024 04:57:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715774271; cv=pass; d=google.com; s=arc-20160816; b=lF0rfmMndPrgpBfeoilEbSSo4VN6nvCKy8z3xkszG05KX1YsxSBfGr9ehZTU6PqJ1t T2fndAQpTttJSb9HG5xgqUhesa7VlSCEnHDNzXs8Dzs7j5jmZgbeeHnti61nRAUbroZS AcRMe8aw17b4SlG6O8ELC8LENkWlz+4dj4YrMpRXBMt1w2SnoDlnIigCM2sZDIWScnFU qzCmo/5SCqo91/myZm+w9HNQ8K3wgfiFi4CboT7BHhQkG2DKJ0TWq7jjwwmbCisLt5Pr AEUf2ibMNd5bhDCIFaKDEuB/jsEOJYOlNH+ouI/0PNjIghiaScL6CgtDuU8CAeiJCk4H NuDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=kCXkXqb9XwSbCACbfI/J06aWDK+woiUsR0o60ggIejw=; fh=jnBiukiKxL3zxB/fLZnL47TPhOTRKMT+HDlhBOOTe74=; b=XEUsBAeiArrTYGtADxI21M7cDwfafUDeGuPfeKtZ7obwIVTPBNgvCPOmtTFJBmBhyw gDJ5HsisVFFBZgN01Bij4EPaKa7zRjAy8AtwqWbQ7SQFhgOaFIdZlUhM2hCziy6YVgKB grR+arwAci5LeZclI9sjgy4ygNR4P4dugAApi9FGzPLO03odrURwd1fX/XvkCidHJylU f11QTse0Bkuo1ON+n7mlniYnMknpueBImPXnEUA7W//j7QWmgECPqTIqOgtipK9ETXfp wddSxEAzgtLp8OtZ2HYuNPwsNwlEt/yuHFMYaZoLcqQUQUhGJ8jY/aCveKLDjC8QjH2/ hYZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=E+uWCMsG; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-7684-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f1d7e50si140989356d6.55.2024.05.15.04.57.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 04:57:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7684-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=E+uWCMsG; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-7684-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9D7301C216F1 for ; Wed, 15 May 2024 11:57:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CE4296EB4D; Wed, 15 May 2024 11:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="E+uWCMsG" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D8214AB4 for ; Wed, 15 May 2024 11:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715774268; cv=none; b=deDBAluQ4rtHRzT8XI/ffSAzpKn4XWQYp9MtX7LZ/Bx8Gute5dhCpqPxX9x0th6YF7wCuKvXB766lfW1fc/uC1eEQa2RiZG5SZHO4817dsZOFwObJr9HqxZmJ0rzP/6a0wHqBczKmGeS6CHB873VDKTEQyGnV13KlQ/+hwKQ3qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715774268; c=relaxed/simple; bh=kCXkXqb9XwSbCACbfI/J06aWDK+woiUsR0o60ggIejw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZwkKu8lmOo58jPIlk4a+yEnMvnGBorXaQycQG8V5q6OrGhE1NwDd2/pKkQEKQ7YTf8/09TGeF0cZr1saGvoMyAmk06qL6S43FDE1vCIYh4/m+d9WpPqzWlT5VO6a7mcKYIHj6DveFBqNK3TCKjz+zd/DbCS7Fa9v+eK4Qvk5WOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=E+uWCMsG; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=kCXkXqb9XwSbCACbfI/J06aWDK+woiUsR0o60ggIejw=; t=1715774267; x=1716983867; b=E+uWCMsGbLhFcPo1cXfNXotxktqp781ZbCEXEGfgHhzrl3h ZnTNa43bxcG6D2CyMOm7/v9D39DPTheG9DmCrw4lc1cEhU/+LvSWFFrSHmqefR/th7Q4C8uFozMoE Ft3ZYVMApfeiMPce/kghomDvF2tkd/Cn117QH/zMgT7YuWUYZYSe/RIovkd0YrNpEEqZpssT7RPFd gezT6ss6Y+ilf2nfEXdleYAg9GaQsZd+O3M44geIpo9hEFQL3OHG03wGXZc0g0ndg0T1j2Ry/Pjt9 K3fTnbWUaLPrwx9ETh2FEpUIM7nICroHuKV+V7J7rshm0oMauYbAqwRuNZfk00jw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1s7DGS-00000006OVu-2SIA; Wed, 15 May 2024 13:57:44 +0200 Message-ID: Subject: Re: [PATCH] wifi: mac80211: handle tasklet frames before stopping From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: syzbot+8830db5d3593b5546d2e@syzkaller.appspotmail.com Date: Wed, 15 May 2024 13:57:43 +0200 In-Reply-To: <20240515135318.b05f11385c9a.I41c1b33a2e1814c3a7ef352cd7f2951b91785617@changeid> References: <20240515135318.b05f11385c9a.I41c1b33a2e1814c3a7ef352cd7f2951b91785617@changeid> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Wed, 2024-05-15 at 13:53 +0200, Johannes Berg wrote: > From: Johannes Berg >=20 > The code itself doesn't want to handle frames from the driver > if it's already stopped, but if the tasklet was queued before > and runs after the stop, then all bets are off. Flush queues > before actually stopping, RX should be off at this point since > all the interfaces are removed already, etc. >=20 > Reported-by: syzbot+8830db5d3593b5546d2e@syzkaller.appspotmail.com >=20 I suspect this might also address https://syzkaller.appspot.com/bug?extid=3Dac648b0525be1feba506 johannes