Received-SPF: pass (google.com: domain of linux-wireless+bounces-7731-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Muna Sinada <quic_msinada@quicinc.com>,  <ath12k@lists.infradead.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: Add Dynamic VLAN support
References: <20240506231752.942567-1-quic_msinada@quicinc.com>
	<b69c3612-3d9c-491a-b98c-03b9997654d7@quicinc.com>
Date: Thu, 16 May 2024 09:34:06 +0300
In-Reply-To: <b69c3612-3d9c-491a-b98c-03b9997654d7@quicinc.com> (Jeff
	Johnson's message of "Mon, 13 May 2024 10:17:18 -0700")
Message-ID: <874jayi7tt.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 5/6/2024 4:17 PM, Muna Sinada wrote:
>> Add support for dynamic VLAN. VLAN group traffic is encapsulated and
>> encrypted in mac80211 and driver needs to set flags for the VLAN group
>> traffic to skip hardware encapsulation and encryption.
>> 
>> VLAN group traffic utilizes ext MSDU and HTT Metadata to set
>> encapsulation type to RAW and encryption type to OPEN in order to
>> inform firmware to skip hardware encapsulation and encryption.
>> 
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>> 
>> Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
>
> My first test of this patch gave intermittent connectivity, but a second test
> didn't show that, so I think my issues were actually with my home router.
> So giving this:
>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> However I do have one question:
>
>> +struct hal_tx_msdu_metadata {
>> +	__le32 info0;
>> +	__le32 rsvd3[6];
>
> why not rsvd0?
>
> If that is OK, Kalle can change this in 'pending'

Muna, please always reply to review comments. Not replying to them gives
an impression that you have ignored them and makes it harder for
maintainers to trust your patches. I noticed you addressed the review
comment in v2 but you still need to answer to review comments.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches