Received-SPF: pass (google.com: domain of linux-wireless+bounces-7735-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] wifi: ath12k: Fix Tx Completion Ring(WBM2SW) Setup
 Failure
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20240510070427.206152-1-quic_nithp@quicinc.com>
References: <20240510070427.206152-1-quic_nithp@quicinc.com>
To: Nithyanantham Paramasivam <quic_nithp@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
 Nithyanantham Paramasivam
	<quic_nithp@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <171584791537.2781522.14910135960105060836.kvalo@kernel.org>
Date: Thu, 16 May 2024 08:25:17 +0000 (UTC)

Nithyanantham Paramasivam <quic_nithp@quicinc.com> wrote:

> We observe intermittent ping failures from the access point (AP) to
> station (STA) in any mode (AP-STA or Mesh) configured. Specifically,
> the transmission completion status is not received at tx completion
> ring id 4 (WBM2SW ring4) for the packets transmitted via TCL DATA
> ring id 3. This prevents freeing up tx descriptors and leads
> to buffer exhaustion.
> 
> Currently, during initialization of the WBM2SW ring, we are directly
> mapping the ring number to the ring mask to obtain the ring mask
> group index. This approach is causing setup failures for WBM2SW
> ring 4. Similarly, during runtime, when receiving incoming
> transmission completion status, the validation of the ring number by
> mapping the interrupted ring mask. This is resulting in
> validation failure. Thereby preventing entry into the completion
> handler ath12k_dp_tx_completion_handler().
> 
> The existing design assumed that the ring numbers would always be
> sequential and could be directly mapped with the ring mask. However,
> this assumption does not hold true for WBM2SW ring 4. Therefore,
> modify the design such that, instead of mapping the ring number,
> the ring ID is mapped with the ring mask.
> 
> According to this design:
> 
> 1. During initialization of the WBM2SW ring, mapping the ring ID
> to the ring mask will ensure obtaining the correct ring mask group
> ID.
> 
> 2. During runtime, validating the interrupted ring mask group ID
> within the transmission completion group is sufficient. This
> approach allows the ring ID to be derived from the interrupted ring
> mask and enables entry into the completion handler.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Nithyanantham Paramasivam <quic_nithp@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

0ce9ab2785e4 wifi: ath12k: Fix tx completion ring (WBM2SW) setup failure

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240510070427.206152-1-quic_nithp@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches